-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting height option breaks the Filter Control extension #7171
Comments
Please provide an Online Example to show your problem. Thanks! |
The bug requires (a minimal example suitable for use on the live editor is included in this GitHub-details snippet)<table
id="table"
data-url="json/data1.json"
data-filter-control="true"
data-height="400"
data-mobile-responsive="true"
data-show-search-clear-button="true">
<thead>
<tr>
<th data-field="id">ID</th>
<th data-field="name"
data-filter-control="input">Item Name</th>
<th data-field="price"
data-filter-control="select"
data-filter-data="var:priceFilter">Item Price</th>
</tr>
</thead>
</table>
<script>
$(function() {
$('#table').bootstrapTable()
});
var priceFilter = ["$0", "$1"];
</script> The cause of the bug appears to be inconsistent results from this In particular, when That causes a subsequent call to I'm not sure yet what is wrong:
Continuing to investigate. |
These could be related to the fact that However: the filter columns controls do not seem to exist within the fixed header - is that inconsistency the problem? |
Also: why does this only happen when the |
Additional findings:
Credit: #6471 (comment) where @mausol identified the first of these behaviours. |
I'm not completely confident that the fix is correct, but I have opened a pull request that resolves this problem for an example case in #7445. |
@kilgorejd @hiephm are you able to confirm whether the code example at https://live.bootstrap-table.com/code/jayaddison/18021 accurately replicates this problem? If possible: thank you. |
One more request for any assistance testing the potential fix for this in #7445 - I'd be glad to receive any feedback about it. |
Bootstraptable version(s) affected
1.22.1
Description
When enabling the height option on my bootstrap-table, the extension for column filters, Filter Control, no longer works, specifically for the 'select' filterControl using filterData like "var:SOMEVAR". The dropdowns are no longer populated. Removing the height option makes everything happy again.
Example(s)
No response
Possible Solutions
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: