You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the most recent release (v0.15.0) I had to introduce a breaking change to crud.CRUDView related to template partials. I originally copied the code dealing with that from a project that used it and didn't think through all of the downstream effects it would have.
I think template partials should be an opt-in thing per-project, and right now that's accomplished via a class attribute enable_template_partials flag on CRUDView. I wonder if moving all the template partial logic to a specific mixin for that would be a good workaround for allowing project's to opt-in, by just adding it to the view class inheritence? This way, CRUDView could be left alone and continue to function without breaking projects using it and you could opt in by choice.
It could also allow a space for expanding the functionality of the template partial rendering, as right now it's just focused on the list view.
In the most recent release (v0.15.0) I had to introduce a breaking change to
crud.CRUDView
related to template partials. I originally copied the code dealing with that from a project that used it and didn't think through all of the downstream effects it would have.I think template partials should be an opt-in thing per-project, and right now that's accomplished via a class attribute
enable_template_partials
flag onCRUDView
. I wonder if moving all the template partial logic to a specific mixin for that would be a good workaround for allowing project's to opt-in, by just adding it to the view class inheritence? This way,CRUDView
could be left alone and continue to function without breaking projects using it and you could opt in by choice.It could also allow a space for expanding the functionality of the template partial rendering, as right now it's just focused on the list view.
The text was updated successfully, but these errors were encountered: