Repository navigation
Commit 488bf65
fix(zbugs-gpui): mark an issue viewed after the server confirms its changes (#186)
The zbugs GPUI end-to-end job failed once on #185 at the viewState check:
`e2e online: passed`, then Postgres had the issue's viewed time before its
modified time.
zbugs' issue trigger stamps `modified` with the time the server's
transaction for a change starts, after the client showed the change. The
one-second view timer took its viewed time from the client's state, so when
it fired before the server had applied the close, the server's stamp came
later. The app marked the issue viewed again a second after the server
confirmed it, but the run had already exited.
The timer now waits until the server has confirmed the pending mutations
before it takes the viewed time, as `max(now, modified)` of the confirmed
issue.
Amp-Thread-ID: https://ampcode.com/threads/T-5a01d9bf-e8fb-479a-8866-c293f3e230d5
Co-authored-by: Amp <amp@ampcode.com>1 parent 2c829ea commit 488bf65
1 file changed
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
1407 | 1407 | | |
1408 | 1408 | | |
1409 | 1409 | | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
1410 | 1423 | | |
1411 | | - | |
1412 | | - | |
| 1424 | + | |
1413 | 1425 | | |
1414 | 1426 | | |
1415 | 1427 | | |
| |||
0 commit comments