fix(zbugs-swift): issue numbers without separators, a badge that fits, and the picker the test taps

The navigation title formatted the issue number for the locale ("#3,000").
On an iPhone the connection badge shows only its dot. The UI test finds the
filters' List picker by its label, which is its title and its value.

Amp-Thread-ID: https://ampcode.com/threads/T-c513a037-a257-45e0-b9a9-15c15edfe859
Co-authored-by: tmm <tmm@tmm.dev>

Author: ampagent

.github/workflows/zbugs-screenshots.yml

@@ -76,18 +76,14 @@ jobs:
           export TEST_RUNNER_ZBUGS_TOKEN
           device="$(xcrun simctl list devices available -j |
             python3 -c 'import json,sys; d=json.load(sys.stdin)["devices"]; print(next(x["udid"] for k,v in d.items() if "iOS" in k for x in v if x["name"].startswith("iPhone")))')"
-          echo "DEVICE=$device" >> "$GITHUB_ENV"
           xcodebuild test -project ZBugs.xcodeproj -scheme ZBugsApp \
             -destination "id=$device" -resultBundlePath "$RUNNER_TEMP/screenshots.xcresult" \
             -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO
-      # With the client's log (os.Logger, subsystem zero).
       - name: Export screenshots
         if: always()
         run: |
           xcrun xcresulttool export attachments \
             --path "$RUNNER_TEMP/screenshots.xcresult" --output-path "$RUNNER_TEMP/screenshots"
-          xcrun simctl spawn "$DEVICE" log show --last 1h --info --style compact \
-            --predicate 'subsystem == "zero"' > "$RUNNER_TEMP/screenshots/client.log" || true
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         if: always()
         with:

apps/zbugs-swift/App/UITests/ScreenshotTests.swift

@@ -49,7 +49,8 @@ final class ScreenshotTests: XCTestCase {
     if UIDevice.current.userInterfaceIdiom == .phone {
       back(app)
     }
-    let listPicker = app.buttons["List"]
+    // A menu picker's label is its title and its value.
+    let listPicker = app.buttons.matching(NSPredicate(format: "label BEGINSWITH 'List,'")).firstMatch
     if expect(listPicker, "the filters' List picker") {
       settle()
       snapshot("4 Filters")

apps/zbugs-swift/Sources/ZBugsUI/IssueDetail.swift

@@ -45,7 +45,8 @@
         .padding()
         .frame(maxWidth: 760, alignment: .leading)
       }
-      .navigationTitle(issue.shortID.map { "Issue #\($0)" } ?? "Issue")
+      // String(_:), or the title formats the number for the locale (3,000).
+      .navigationTitle(issue.shortID.map { "Issue #" + String($0) } ?? "Issue")
       .toolbar {
         if canEdit {
           ToolbarItem {

apps/zbugs-swift/Sources/ZBugsUI/RootView.swift

@@ -199,14 +199,21 @@
         case .connected: (.green, "Connected")
         case .connecting, .initializing: (.yellow, "Connecting")
         case .needsAuth: (.orange, "Log In Again")
-        case .disconnected, .error, .closed: (.red, "Offline")
+        case .disconnected, .closed: (.red, "Offline")
+        case .error: (.red, "Error")
         }
       SwiftUI.Label {
         Text(text)
       } icon: {
         Image(systemName: "circle.fill").foregroundStyle(color)
       }
-      .labelStyle(.titleAndIcon)
+      #if os(iOS)
+        // The text doesn't fit in an iPhone's navigation bar.
+        .labelStyle(.iconOnly)
+        .accessibilityLabel(text)
+      #else
+        .labelStyle(.titleAndIcon)
+      #endif
       .font(.caption)
       .help(String(describing: connection.state))
     }