feat(zero-swift): drop the generic tx.mutate.insert and upsert

tx.mutate.<table> is now the one way to write, as in JS. Generic code
uses TypedTableMutator<R>(tx.mutate); hand-written rows without a
generated member use the untyped tx.mutate.<table> with columnValues.

Amp-Thread-ID: https://ampcode.com/threads/T-01a17664-8fd0-76be-8fd5-75ac6e7aa0d8
Co-authored-by: tmm <tmm@tmm.dev>

Author: ampagent

.changeset/typed-table-mutators.md

@@ -7,6 +7,9 @@
 To migrate, regenerate with `npx zero-swift codegen`, then replace dictionaries passed to `tx.mutate.<table>` with the typed values:
 
 ```diff
+- try tx.mutate.insert(Issue(id: id, title: title, ...))
++ try tx.mutate.issue.insert(.init(id: id, title: title, ...))
+
 - try tx.mutate.issue.insert(["id": .string(id), "title": .string(title), ...])
 + try tx.mutate.issue.insert(.init(id: id, title: title, ...))
 
@@ -20,4 +23,4 @@ To migrate, regenerate with `npx zero-swift codegen`, then replace dictionaries
 + try tx.mutate.issue.delete(.init(id: id))
 ```
 
-`tx.mutate.insert(row)` and `tx.mutate.upsert(row)` still work. For untyped writes, `tx.mutate.table("issue")` takes dictionaries as before.
+`tx.mutate.insert(row)` and `tx.mutate.upsert(row)` are gone: `tx.mutate.<table>` is the one way to write. Generic code can use `TypedTableMutator<R>(tx.mutate)`, and `tx.mutate.table("issue")` takes dictionaries for untyped writes.

swift/Sources/Zero/Client/Transaction.swift

@@ -131,16 +131,6 @@ public struct TransactionMutate {
   /// The untyped CRUD operations on `name`, with values keyed by client
   /// column name.
   public func table(_ name: String) -> TableMutator { TableMutator(tx: tx, table: name) }
-
-  /// Inserts a row unless one with its primary key exists.
-  public func insert<R: ZeroRow>(_ row: R) throws {
-    try tx.insert(R.tableName, row.columnValues)
-  }
-
-  /// Inserts a row, or replaces the columns of the existing one.
-  public func upsert<R: ZeroRow>(_ row: R) throws {
-    try tx.upsert(R.tableName, row.columnValues)
-  }
 }
 
 /// The CRUD operations on one table (`TableCRUD` in

swift/Sources/ZeroBenchmarks/Fixtures.swift

@@ -78,14 +78,14 @@ struct UpdateUser: Codable, Sendable {
 enum Mutators {
   static let insertUsers = defineMutator("insertUsers") { (tx, args: InsertUsers) in
     for n in args.from..<args.from + args.count {
-      try tx.mutate.insert(User(n))
+      try tx.mutate.user.insert(User(n).columnValues)
     }
   }
   static let updateUser = defineMutator("updateUser") { (tx, args: UpdateUser) in
     var row = User(args.a)
     let v = Double(args.value)
     (row.b, row.c, row.d, row.e, row.f, row.g, row.h, row.i, row.j) = (v, v, v, v, v, v, v, v, v)
-    try tx.mutate.upsert(row)
+    try tx.mutate.user.upsert(row.columnValues)
   }
   static let all: [any Mutator<Void>] = [insertUsers, updateUser]
 }

swift/Tests/AppleTests/Notes.swift

@@ -40,7 +40,7 @@ enum Notes {
   }
 
   static let put = defineMutator("note.put") { (tx, note: Put) in
-    try tx.mutate.upsert(Note(id: note.id, text: note.text))
+    try tx.mutate.note.upsert(Note(id: note.id, text: note.text).columnValues)
   }
   static let remove = defineMutator("note.remove") { (tx, id: String) in
     try tx.mutate.note.delete(["id": .string(id)])

swift/Tests/E2ETests/ClientE2ETests.swift

@@ -20,8 +20,8 @@ enum E2EApp {
   }
 
   static let create = defineMutator("issue.create") { (tx, args: CreateIssue) in
-    try tx.mutate.insert(
-      TestIssue(
+    try tx.mutate.issue.insert(
+      .init(
         id: args.id, title: args.title, description: "", closed: false, ownerId: args.ownerId,
         createdAt: 100))
   }

swift/Tests/ZeroTests/ClientAPITests.swift

@@ -22,8 +22,8 @@ import ZeroTesting
     zql.issue.where(\.ownerId, auth.userID).orderBy(\.id, .asc)
   }
   static let create = defineMutator("issue.create") { (tx, args: CreateIssue, auth: Auth) in
-    try tx.mutate.insert(
-      Issue(
+    try tx.mutate.issue.insert(
+      .init(
         id: args.id, title: args.title, description: "", closed: false,
         ownerId: args.ownerId ?? auth.userID, createdAt: 1))
   }