Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalive requests are terminated when they shouldn't be? #1669

Open
smaug---- opened this issue Jun 6, 2023 · 2 comments
Open

keepalive requests are terminated when they shouldn't be? #1669

smaug---- opened this issue Jun 6, 2023 · 2 comments

Comments

@smaug----
Copy link

https://fetch.spec.whatwg.org/#fetch-groups says
"whose request’s done flag is unset or keepalive is false"

I think that should use "and", not "or". We don't want to cancel not-done keepalives there, I believe.

@annevk
Copy link
Member

annevk commented Jun 16, 2023

@noamr maybe fix this as part of #1647 or rather after? I believe that PR is changing this line already.

I went back through blame when this was first mentioned on Chat and I believe it's always been wrong.

@noamr
Copy link
Contributor

noamr commented Jun 18, 2023

@noamr maybe fix this as part of #1647 or rather after? I believe that PR is changing this line already.

I went back through blame when this was first mentioned on Chat and I believe it's always been wrong.

Done. That PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants