Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshed source file linting #1

Closed
domenic opened this issue Jan 6, 2017 · 4 comments
Closed

Bikeshed source file linting #1

domenic opened this issue Jan 6, 2017 · 4 comments

Comments

@domenic
Copy link
Member

domenic commented Jan 6, 2017

Here are some things it would be nice to have Travis verify for us, for all the Bikeshed-using specs:

  • Line length, I guess ignoring inside <pre> blocks---any other exceptions?
  • No trailing whitespace

Please add more ideas!

@annevk
Copy link
Member

annevk commented Jan 7, 2017

Line length might be tricky as I don't wrap "inline" elements (I never quite remember the new terms). I guess you could detect that since the start and end tag are on the same line.

@foolip
Copy link
Member

foolip commented Jan 25, 2017

I had some terrible code in https://github.com/w3c/webvtt/blob/gh-pages/format.py and https://github.com/WICG/mediasession/blob/master/format.py that could possibly be reduced to just a linter. Reformatting isn't an impossible problem, although not wrapping "inline" elements makes it harder and I never bothered.

@annevk
Copy link
Member

annevk commented Mar 29, 2017

whatwg/resources.whatwg.org#51 is something that seems reasonably simple to add.

@annevk
Copy link
Member

annevk commented Jan 8, 2018

Going to close this in favor of whatwg/whatwg.org#66 which has a concrete working suggestion, but needs a few more tweaks.

It doesn't tackle line length (see also #31), but I don't think we have a good way to deal with line length exceptions yet. Once someone figures that out it seems that repository would be the place to make the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants