Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing maxActions #110

Open
hober opened this issue Oct 11, 2017 · 3 comments
Open

Consider removing maxActions #110

hober opened this issue Oct 11, 2017 · 3 comments

Comments

@hober
Copy link

hober commented Oct 11, 2017

ISTM exposing maxActions increases the fingerprinting surface of the platform to little benefit. It might be worth dropping, or perhaps not requiring implementations to expose it.

@beverloo
Copy link
Member

In my view, the ideal number of buttons is platform (and OS version) specific as it largely depends on their presentation. Influencers include whether or not button icons are visible, horizontal or vertical stacking and/or whether they're in a drop-down menu that may hide other functionality.

Based on the sort of cross-platform inconsistency problems that developers run in to for notifications, I would personally prefer providing more information rather than less. Maybe even carefully erring towards some sort of getCapabilitiesAndImageResolutions() call. Is there a particular fingerprinting association that you're worried about that couldn't be derived from the user agent?

@annevk
Copy link
Member

annevk commented Feb 27, 2018

The other problem with this feature, and actions in general, is that it seems there's only one implementation.

@beverloo
Copy link
Member

I would love to learn why other vendors haven't implemented support for actions. We're seeing that >5% of desktop and >10% of mobile notifications includes at least one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants