Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Call Object.freeze on action" #74

Open
domenic opened this issue May 12, 2016 · 3 comments · May be fixed by #125
Open

"Call Object.freeze on action" #74

domenic opened this issue May 12, 2016 · 3 comments · May be fixed by #125

Comments

@domenic
Copy link
Member

domenic commented May 12, 2016

https://notifications.spec.whatwg.org/#object-members

Call Object.freeze on action, to prevent accidental mutation by scripts.

This should not call the author-overrideable Object.freeze. Instead, call SetIntegrityLevel(action, "frozen").
@beverloo
Copy link
Member

/cc @johnmellor

@annevk
Copy link
Member

annevk commented May 12, 2016

Which probably does not work due to IDL expecting us to use IDL objects. But I guess we can assume that distinction will be removed.

@domenic
Copy link
Member Author

domenic commented May 12, 2016

Meh, maybe throw in a "the JavaScript object corresponding to action"

@domenic domenic mentioned this issue Jun 8, 2016
Merged
@annevk annevk mentioned this issue Apr 24, 2017
Open
annevk added a commit that referenced this issue Feb 27, 2018
@annevk
Use SetIntegrityLevel instead of Object.freeze()
5eb2899 
Verbose, but clear and correct.

Fixes #74.
@annevk annevk linked a pull request Feb 27, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SetIntegrityLevel instead of Object.freeze() whatwg/notifications
3 participants
@beverloo @domenic @annevk