media: set renomination on the remote description as well

Author: nandito

packages/media/src/webrtc/P2pRtcManager.ts

@@ -490,6 +490,7 @@ export default class P2pRtcManager implements RtcManager {
                     ? MAXIMUM_TURN_BANDWIDTH_UNLIMITED
                     : MAXIMUM_TURN_BANDWIDTH,
                 deprioritizeH264Encoding,
+                iceRenominationOn: this._features.iceRenominationOn,
             });
 
             this.totalSessionsCreated++;

packages/media/src/webrtc/Session.ts

@@ -33,6 +33,7 @@ export default class Session {
     registerConnected: any;
     offerOptions: { offerToReceiveAudio: boolean; offerToReceiveVideo: boolean };
     _deprioritizeH264Encoding: any;
+    _iceRenominationOn: boolean;
     clientId: any;
     peerConnectionConfig: any;
     shouldAddLocalVideo: any;
@@ -44,11 +45,13 @@ export default class Session {
         bandwidth,
         maximumTurnBandwidth,
         deprioritizeH264Encoding,
+        iceRenominationOn,
     }: {
         peerConnectionId: any;
         bandwidth: any;
         maximumTurnBandwidth: any;
         deprioritizeH264Encoding: any;
+        iceRenominationOn: boolean;
     }) {
         this.peerConnectionId = peerConnectionId;
         this.relayCandidateSeen = false;
@@ -78,6 +81,7 @@ export default class Session {
         });
         this.offerOptions = { offerToReceiveAudio: true, offerToReceiveVideo: true };
         this._deprioritizeH264Encoding = deprioritizeH264Encoding;
+        this._iceRenominationOn = iceRenominationOn;
     }
 
     setAndGetPeerConnection({
@@ -195,6 +199,7 @@ export default class Session {
 
         sdp = sdpModifier.filterMidExtension(sdp);
         sdp = sdpModifier.filterMsidSemantic(sdp);
+        if (this._iceRenominationOn) sdp = sdpModifier.enableIceRenomination(sdp);
 
         const desc = { type: message.type, sdp };
         // Create an answer to send to the client that sent the offer
@@ -217,7 +222,8 @@ export default class Session {
     }
 
     handleAnswer(message: any) {
-        const sdp = sdpModifier.filterMsidSemantic(message.sdp);
+        let sdp = sdpModifier.filterMsidSemantic(message.sdp);
+        if (this._iceRenominationOn) sdp = sdpModifier.enableIceRenomination(sdp);
 
         const desc = { type: message.type, sdp };
         return this._setRemoteDescription(desc).then(
@@ -226,7 +232,7 @@ export default class Session {
             },
             (e: any) => {
                 logger.warn("Could not set remote description from remote answer: ", e);
-            }
+            },
         );
     }
 
@@ -428,7 +434,7 @@ export default class Session {
                     videoTransceiver?.direction !== "recvonly" &&
                     videoTransceiver?.receiver?.track?.kind === "video" &&
                     !excludedTrackIds.includes(videoTransceiver?.receiver?.track?.id) &&
-                    !excludedTrackIds.includes(videoTransceiver?.sender?.track?.id)
+                    !excludedTrackIds.includes(videoTransceiver?.sender?.track?.id),
             )
             .forEach((videoTransceiver: any) => {
                 videoTransceiver.direction = enable ? "sendonly" : "sendrecv";