media: do not add renomination in Firefox

Author: nandito

packages/media/src/webrtc/Session.ts

@@ -210,8 +210,10 @@ export default class Session {
                 return this.pc.createAnswer();
             })
             .then((answer: any) => {
+                answerToSignal = { ...answer };
+                // Do not include the renegotiation flag in the signaling
+                // message as it may not be supported by the other side.
                 if (this._iceRenominationOn) answer.sdp = sdpModifier.enableIceRenomination(answer.sdp);
-                answerToSignal = answer;
                 return this.pc.setLocalDescription(answer);
             })
             .then(() => {

packages/media/src/webrtc/sdpModifier.ts

@@ -154,6 +154,10 @@ export function deprioritizeH264(sdp: any) {
 // replace `a=ice-options:trickle` with `a=ice-options:trickle renomination`
 // https://datatracker.ietf.org/doc/html/draft-thatcher-ice-renomination-00
 export function enableIceRenomination(sdp: any) {
+    if (browserName === "firefox") {
+        return sdp;
+    }
+
     return (
         SDPUtils.splitLines(sdp.trim())
             .map((line) => (line === "a=ice-options:trickle" ? "a=ice-options:trickle renomination" : line))

packages/media/tests/webrtc/sdpModifier.spec.ts

@@ -68,6 +68,23 @@ describe("sdpModifier", () => {
     });
 
     describe("enableIceRenomination", () => {
+        afterEach(() => {
+            jest.resetModules();
+        });
+
+        it("returns the original sdp if the browserName is firefox", () => {
+            jest.mock("webrtc-adapter", () => ({
+                browserDetails: {
+                    browser: "firefox",
+                },
+            }));
+            const sdp = getVideoSdpString();
+
+            const modifiedSdp = sdpModifier.enableIceRenomination(sdp);
+
+            expect(modifiedSdp).toEqual(sdp);
+        });
+
         it("returns the original sdp if it has no ice-options:tickle", () => {
             const sdp = getVideoSdpString();