Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on uri-js threatens node 0.8 - node 4.x compatibility #132

Open
ethanherbertson opened this issue Apr 13, 2018 · 0 comments
Open

Comments

@ethanherbertson
Copy link

The uri-js module makes no claims about what engines it supports, but sadly all recent versions of it (and indeed all versions still tagged/available on GitHub) rely on punycode 2.x, which only claims compatibility with node >= 6.0. (I've just filed garycourt/uri-js#27 on uri-js to suggest he downgrade his dependency or at least add a "node >= 6.0" to his package.json.)

This module claims it supports node >= 0.8, but that nested dependency means it cannot (safely) claim to.

To fix this you'd either have to wait for uri-js to get "fixed", or you'd have to fork it or switch to a different URI library. Not sure which of those you'd prefer. In the meantime it's worth considering updating your supported engines to node >= 6.0.

@ethanherbertson ethanherbertson changed the title Dependency on uri-js breaks node 0.8 - node 4.x compatibility Dependency on uri-js threatens node 0.8 - node 4.x compatibility Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant