Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Feature request: Align solara.Select & solara.SelectMultiple API with standard vue parameter names #837

Open
ntjess opened this issue Oct 25, 2024 · 0 comments

Comments

@ntjess
Copy link
Contributor

ntjess commented Oct 25, 2024

solara.Select{Multiple} uses custom parameter names of values/all_values, when it might make more sense to use value and items.

For reference, consider the v-select widget:

items
Can be an array of objects or strings. By default objects should have title and value properties, and can optionally have a props property containing any VListItem props. Keys to use for these can be changed with the item-title, item-value, and item-props props.

This would be a breaking change, but I think it's worthwhile to adopt the standard naming conventions before more components are created

As a side note, it would also resolve the confusion between values vs. on_value (no s in the callback param) for SelectMultiple, so at least there is some precedent for this breaking change to provide internal consistency even in the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant