address PR comments

Author: caldrian

WireCalling/Sources/WireCallingUI/Resources/Localization/en.lproj/Localizable.strings

@@ -94,3 +94,6 @@
 "wireMeetings.schedule.members.retry.button" = "Retry";
 "wireMeetings.schedule.members.selected.title" = "Selected";
 "wireMeetings.schedule.members.contacts.title" = "Contacts";
+
+"wireMeetings.schedule.error.expiredStartDate.title" = "Choose a later start time";
+"wireMeetings.schedule.error.expiredStartDate.message" = "Meetings can only be updated with a start time up to 24 hours in the past. Choose a later start time and save again.";

WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormView.swift

@@ -77,6 +77,16 @@ struct MeetingFormView: View {
                     dismissButton: .default(Text(Strings.Error.Alert.ok))
                 )
             }
+            .alert(
+                Strings.Error.ExpiredStartDate.title,
+                isPresented: $viewModel.hasExpiredStartDateError
+            ) {
+                Button(Strings.Error.Alert.ok) {
+                    expandedField = .startDate
+                }
+            } message: {
+                Text(Strings.Error.ExpiredStartDate.message)
+            }
             .alert(
                 Strings.Error.ConversationName.title,
                 isPresented: $viewModel.hasConversationNameUpdateError
@@ -141,7 +151,7 @@ struct MeetingFormView: View {
             dateTimeRow(
                 label: Strings.Time.starts,
                 date: $viewModel.startDate,
-                range: viewModel.startDateRange,
+                range: viewModel.startDatePickerRange,
                 maximumDate: nil,
                 dateField: .startDate,
                 timeField: .startTime

WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormViewModel.swift

@@ -104,6 +104,13 @@ package final class MeetingFormViewModel {
         return Calendar.current.startOfDay(for: earliest)...
     }
 
+    /// Keep the current selection representable even if it expires while the form is open.
+    /// Submission validates against the backend's current window, not this display range.
+    var startDatePickerRange: PartialRangeFrom<Date> {
+        guard mode.isEdit else { return startDateRange }
+        return min(startDate, startDateRange.lowerBound)...
+    }
+
     /// Acceptance: the end picker must stay on the start date, with 23:45 as the latest available time.
     var endDateRange: ClosedRange<Date> {
         let latestEndDate = Self.latestEndDate(for: startDate)
@@ -126,6 +133,8 @@ package final class MeetingFormViewModel {
     /// logged; the view shows a generic alert.
     var hasError = false
 
+    var hasExpiredStartDateError = false
+
     /// Set when the meeting was saved but its dedicated conversation could not be renamed.
     var hasConversationNameUpdateError = false
     private var meetingPendingConversationNameUpdate: Meeting?
@@ -204,6 +213,11 @@ package final class MeetingFormViewModel {
         // unexpectedly). Consider making load(pageSize:) return/throw on failure so reloadLoadedMeetings() can restore
         // futureOffset (and possibly coalesce missed reloads while isLoading is true).
         guard !isLoading else { return }
+        hasExpiredStartDateError = false
+        if mode.isEdit, startDate < currentDateProvider.now.addingTimeInterval(-TimeInterval.oneDay) {
+            hasExpiredStartDateError = true
+            return
+        }
         isLoading = true
         hasError = false
         hasConversationNameUpdateError = false

WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/MeetingFormViewModelTests.swift

@@ -457,6 +457,52 @@ struct MeetingFormViewModelTests {
         #expect(viewModel.startDateRange.lowerBound == dateProviderMock.now.addingTimeInterval(-86_400))
     }
 
+    @Test("editing an expired non-recurring meeting preserves its dates but prevents submission")
+    func editMode_ExpiredNonRecurringMeeting() async {
+        let original = makeEditableMeeting(
+            start: dateProviderMock.now.addingTimeInterval(-3 * 86_400),
+            recurrence: nil
+        )
+        let viewModel = makeViewModel(mode: .edit(original))
+
+        #expect(viewModel.startDate == original.start)
+        #expect(viewModel.startDatePickerRange.contains(viewModel.startDate))
+
+        await viewModel.submit()
+
+        #expect(viewModel.hasExpiredStartDateError)
+        #expect(!viewModel.isLoading)
+        let rejectedArguments = updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingReceivedArguments
+        #expect(rejectedArguments == nil)
+    }
+
+    @Test("saving rechecks the current window and allows retry after correcting the start time")
+    func submit_EditModeStartDateExpiresWhileEditing() async {
+        let original = makeEditableMeeting(start: dateProviderMock.now.addingTimeInterval(-86_400))
+        let viewModel = makeViewModel(mode: .edit(original))
+        dateProviderMock.now = dateProviderMock.now.addingTimeInterval(1)
+
+        #expect(viewModel.startDatePickerRange.contains(viewModel.startDate))
+        await viewModel.submit()
+
+        #expect(viewModel.hasExpiredStartDateError)
+        let rejectedArguments = updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingReceivedArguments
+        #expect(rejectedArguments == nil)
+
+        viewModel.startDate = dateProviderMock.now
+        updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingReturnValue =
+            meeting
+        await viewModel.submit()
+
+        #expect(!viewModel.hasExpiredStartDateError)
+        let savedArguments = updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingReceivedArguments
+        #expect(savedArguments?.startTime == dateProviderMock.now)
+    }
+
     @Test("editing preserves and submits recurring start times within 24 hours", arguments: [0.0, 3600.0, 86_400.0])
     func editMode_RecentRecurringMeetingPreservesDates(secondsAgo: TimeInterval) async throws {
         let original = makeEditableMeeting(start: dateProviderMock.now.addingTimeInterval(-secondsAgo))