fix early return

Author: caldrian

WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormViewModel.swift

@@ -213,15 +213,15 @@ package final class MeetingFormViewModel {
         // unexpectedly). Consider making load(pageSize:) return/throw on failure so reloadLoadedMeetings() can restore
         // futureOffset (and possibly coalesce missed reloads while isLoading is true).
         guard !isLoading else { return }
+        hasError = false
+        hasConversationNameUpdateError = false
+        meetingPendingConversationNameUpdate = nil
         hasExpiredStartDateError = false
         if mode.isEdit, startDate < currentDateProvider.now.addingTimeInterval(-TimeInterval.oneDay) {
             hasExpiredStartDateError = true
             return
         }
         isLoading = true
-        hasError = false
-        hasConversationNameUpdateError = false
-        meetingPendingConversationNameUpdate = nil
         defer { isLoading = false }
         do {
             let meeting = try await saveMeeting()

WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/MeetingFormViewModelTests.swift

@@ -477,6 +477,36 @@ struct MeetingFormViewModelTests {
         #expect(rejectedArguments == nil)
     }
 
+    @Test("expired submission clears previous save errors", arguments: [false, true])
+    func submit_ExpiredStartClearsPreviousError(conversationNameFailed: Bool) async {
+        let original = makeEditableMeeting(start: dateProviderMock.now.addingTimeInterval(-86_400))
+        let viewModel = makeViewModel(mode: .edit(original))
+        let error: any Error
+        if conversationNameFailed {
+            error = UpdateMeetingUseCaseError.conversationNameUpdateFailed(original)
+        } else {
+            error = URLError(.badServerResponse)
+        }
+        updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingThrowableError =
+            error
+
+        await viewModel.submit()
+        #expect(viewModel.hasError == !conversationNameFailed)
+        #expect(viewModel.hasConversationNameUpdateError == conversationNameFailed)
+
+        dateProviderMock.now = dateProviderMock.now.addingTimeInterval(1)
+        await viewModel.submit()
+
+        #expect(viewModel.hasExpiredStartDateError)
+        #expect(!viewModel.hasError)
+        #expect(!viewModel.hasConversationNameUpdateError)
+        #expect(!viewModel.isLoading)
+        let callsCount = updateMeetingUseCaseMock
+            .invokeMeetingMeetingTitleStringStartTimeDateEndTimeDateRecurrenceMeetingRecurrenceParticipantsMeetingMemberMeetingCallsCount
+        #expect(callsCount == 1)
+    }
+
     @Test("saving rechecks the current window and allows retry after correcting the start time")
     func submit_EditModeStartDateExpiresWhileEditing() async {
         let original = makeEditableMeeting(start: dateProviderMock.now.addingTimeInterval(-86_400))