WPB-28377: address review nits (changelog wording, DB-side cleanup cutoff)

Author: blackheaven

changelog.d/0-release-notes/WPB-28377-remove-redis

@@ -11,6 +11,7 @@ Operators must:
 - Add the new required configuration `gundeck.config.postgresql` (plus
   `postgresqlPool`, and optionally `secrets.pgPassword` for the password file),
   following the same format as brig's postgresql settings.
-- Presence data does not carry over: the presence cache starts empty on
-  upgrade and refills as clients reconnect.
-- The `redis-ephemeral` and `reaper` helm charts have been removed.
+- Restart all cannons after deployment is successful. Presence data does
+  not carry over, this will make sure all clients reconnect after the
+  presence data is being written to PostgreSQL.
+- Stop deploying `redis-ephemeral` and `reaper`, these have been removed.

services/gundeck/src/Gundeck/Presence/Data.hs

@@ -100,10 +100,7 @@ deleteAll pp =
 -- presence rows; this only guards against leaks from abnormally dead pods
 -- (replaces the redis key TTL).
 cleanup :: Gundeck ()
-cleanup = do
-  nowMs <- posixTime
-  let cutoff = msToUtc (fromIntegral (ms nowMs - 7 * 24 * 60 * 60 * 1000))
-  runPool $ statement cutoff deleteStale
+cleanup = runPool $ statement () deleteStale
 
 -- Helpers -------------------------------------------------------------------
 
@@ -170,9 +167,9 @@ deleteMany =
       AND p.created_at <= d.created_at
   |]
 
-deleteStale :: Statement UTCTime ()
+deleteStale :: Statement () ()
 deleteStale =
   [resultlessStatement|
     DELETE FROM presence
-    WHERE created_at < ($1 :: timestamptz)
+    WHERE created_at < now() - interval '7 days'
   |]