Optimize overlay visibility logic (#3084)

* Optimize overlay visibility logic

Also renames base_wire_entity's overlay visibility function to ENT:WireBeingLookedAtByLocalPlayer()

* Don't rename any functions

* Better last looked at check

Author: thecraftianman

lua/entities/base_wire_entity.lua

@@ -11,11 +11,6 @@ ENT.IsWire = true
 
 if CLIENT then
 	local wire_drawoutline = CreateClientConVar("wire_drawoutline", 1, true, false)
-	-- Funny reverse-detour because this function is sometimes nil and sometimes not, but is never nil when drawing for the first time.
-	local function beingLookedAtByLocalPlayer(self)
-		beingLookedAtByLocalPlayer = BaseClass.BeingLookedAtByLocalPlayer
-		return beingLookedAtByLocalPlayer(self)
-	end
 
 	function ENT:Initialize()
 		self.NextRBUpdate = CurTime() + 0.25
@@ -232,7 +227,7 @@ if CLIENT then
 
 	-- Custom better version of this base_gmodentity function
 	function ENT:BeingLookedAtByLocalPlayer()
-		local trbool = beingLookedAtByLocalPlayer(self)
+		local trbool = BaseClass.BeingLookedAtByLocalPlayer(self)
 		local self_table = self:GetTable()
 
 		if self_table.PlayerWasLookingAtMe ~= trbool then
@@ -251,15 +246,37 @@ if CLIENT then
 		return trbool
 	end
 
+	local looked_at
+
+	-- Shared by all derivative entities to determine if the overlay should be visible
+	hook.Add("Think", "wire_base_lookedatbylocalplayer", function()
+		local ply = LocalPlayer()
+		if not IsValid(ply) then
+			looked_at = nil
+			return
+		end
+
+		local cur_ent = ply:GetEyeTrace().Entity
+
+		if cur_ent ~= looked_at and IsValid(looked_at) and looked_at.IsWire then
+			looked_at:BeingLookedAtByLocalPlayer()
+		end
+
+		if cur_ent.IsWire and cur_ent:BeingLookedAtByLocalPlayer() then
+			looked_at = cur_ent
+		else
+			looked_at = nil
+		end
+	end)
+
 	function ENT:DoNormalDraw(nohalo, notip)
-		local looked_at = self:BeingLookedAtByLocalPlayer()
-		if not nohalo and wire_drawoutline:GetBool() and looked_at then
+		if not nohalo and wire_drawoutline:GetBool() and looked_at == self then
 			self:DrawEntityOutline()
 			self:DrawModel()
 		else
 			self:DrawModel()
 		end
-		if not notip and looked_at then
+		if not notip and looked_at == self then
 			self:AddWorldTip()
 		end
 	end