Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Tabs client:visible> in Docs code doesn't sync tabs anymore #4588

Closed
ElianCodes opened this issue Sep 7, 2023 · 4 comments
Closed

<Tabs client:visible> in Docs code doesn't sync tabs anymore #4588

ElianCodes opened this issue Sep 7, 2023 · 4 comments
Labels
bug Something on the site isn't working

Comments

@ElianCodes
Copy link
Member

📝 Issue Description

We had to change <Tabs client:visible> to <Tabs client:idle> in the docs code {Astro v3 PR](#4461).

This is simply an issue to track that we changed it and probably need to change it back sometime in the future!

📋 On which page(s) it occurs

all pages where the <Tabs> Preact component is used

🤔 Expected Behavior

🤷‍♂️

👀 Current Behavior

🙅‍♂️

🖥️ Browser

All of 'em

📄 Additional Information

No response

@ElianCodes ElianCodes added the bug Something on the site isn't working label Sep 7, 2023
@dreyfus92
Copy link
Member

Hey @ElianCodes I was testing the website on my end and tabs seem to be syncing for me on chrome & safari. I'm curious about which browser are you using.

@sarah11918
Copy link
Member

@ElianCodes can you confirm whether this is still something to be concerned about with the migration to Starlight?

@TheOtterlord
Copy link
Member

This is fixed in the Starlight migration with the replacement of the Preact component

@ElianCodes
Copy link
Member Author

Right! I kinda forgot about this! Thanks @TheOtterlord !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something on the site isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants