Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Fix clipping issues #12575

Closed
backwardstruck opened this issue Sep 10, 2024 · 6 comments
Closed

[Woo POS] Fix clipping issues #12575

backwardstruck opened this issue Sep 10, 2024 · 6 comments
Assignees

Comments

@backwardstruck
Copy link
Contributor

backwardstruck commented Sep 10, 2024

This issue is to address all clipping issues mentioned in P2 for POS. More context here

Design. Products Screen bottom This shadow should be clipped to the line. If this is too technically difficult, please just have the second transport dark line instead.

Screenshot 2024-09-11 at 16 58 06

❓ Design. Products Screen bottom Adding a product causes the clipping to break briefly. This looks better when the other views are fixed.

Screenshot 2024-09-11 at 16 58 36

❓ Design. Products Screen bottom This shadow also needs to be clipped at the top.

Screenshot 2024-09-11 at 16 59 05

❓ Design. Checkout Screen bottom Something is clipping the cards/shadows here before the edge of the screen.

Screenshot 2024-09-11 at 16 59 36
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

@backwardstruck
Copy link
Contributor Author

Image

@backwardstruck backwardstruck changed the title [Woo POS] Fix clipping issues on product/cart screens [Woo POS] Fix clipping issues Sep 11, 2024
@backwardstruck
Copy link
Contributor Author

backwardstruck commented Sep 17, 2024

@joe-keenan as far as I can tell, this other issue listed is already fixed:

"❓ Design. Checkout Screen bottom Something is clipping the cards/shadows here before the edge of the screen."

Here's a screenshot of my PR:

Screenshot_20240917_162253

@joe-keenan
Copy link

Hey @backwardstruck, the screenshot in your comment shows the products/cart screen, but my comment was referring to the cart/checkout screen. I think what’s happening is that the white background behind the “Check out” button doesn’t entirely disappear when the cart transitions.

@backwardstruck
Copy link
Contributor Author

Hey @backwardstruck, the screenshot in your comment shows the products/cart screen, but my comment was referring to the cart/checkout screen. I think what’s happening is that the white background behind the “Check out” button doesn’t entirely disappear when the cart transitions.

Sorry, you're right. I shouldn't have cropped that screenshot so closely. In that case this should probably be a separate ticket. Thanks for the additional info. To me it looks like we fixed that when we removed some of the Compose views that were nested there. Let me know if it's still not right.

Here's how trunk looks on the cart/checkout screen:

Screenshot_20240923_153131

Screenshot_20240923_153322

@joe-keenan
Copy link

That looks like it’s been fixed. Thanks for posting it here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants