-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Fix clipping issues #12575
Comments
🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue. |
@joe-keenan as far as I can tell, this other issue listed is already fixed: "❓ Design. Checkout Screen bottom Something is clipping the cards/shadows here before the edge of the screen." Here's a screenshot of my PR: |
Hey @backwardstruck, the screenshot in your comment shows the products/cart screen, but my comment was referring to the cart/checkout screen. I think what’s happening is that the white background behind the “Check out” button doesn’t entirely disappear when the cart transitions. |
Sorry, you're right. I shouldn't have cropped that screenshot so closely. In that case this should probably be a separate ticket. Thanks for the additional info. To me it looks like we fixed that when we removed some of the Compose views that were nested there. Let me know if it's still not right. Here's how trunk looks on the cart/checkout screen: |
That looks like it’s been fixed. Thanks for posting it here! |
This issue is to address all clipping issues mentioned in P2 for POS. More context here
Design. Products Screen bottom This shadow should be clipped to the line. If this is too technically difficult, please just have the second transport dark line instead.
❓ Design. Products Screen bottom Adding a product causes the clipping to break briefly. This looks better when the other views are fixed.
❓ Design. Products Screen bottom This shadow also needs to be clipped at the top.
❓ Design. Checkout Screen bottom Something is clipping the cards/shadows here before the edge of the screen.
The text was updated successfully, but these errors were encountered: