Skip to content

Correctly handle JS assets translatable strings #24

@wordpressfan

Description

@wordpressfan

Is your feature request related to a problem? Please describe.
From the previous version, we introduced some assets inside this package, and we added a few translatable strings there but those are using the placeholder domain %domain% which should be replaced by each plugin's translation domain, but here this is not the case because we only apply this replacement on php files.

Describe the solution you'd like
We need to extend this to apply on js files in assets directory.

Describe alternatives you've considered
Make this discovery dynamic without specifying any files, just to search all library files for the %domain% and replace it with the plugin's domain.

Additional context
https://github.com/wp-media/plugin-family/blob/v1.0.5/src/PostInstall.php#L14-L19

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions