More work on warnings

Author: gunterkoenigsmann

.coverity/coverity.sh

@@ -64,7 +64,7 @@ echo -e "\033[33;1mExtracting Coverity Scan Analysis Tool...\033[0m"
 tar xzf coverity_tool.tgz
 
 
-TOOL_DIR=$(find -type d -name 'cov-analysis*')
+TOOL_DIR=$(find . -type d -name 'cov-analysis*')
 export PATH=$TOOL_DIR/bin:$PATH
 
 # Build

.mdlrc

@@ -0,0 +1 @@
+rules "~MD003" "~MD004" "~MD007" "~MD025" "~MD032"

NEWS.md

@@ -51,7 +51,7 @@
 
 # 23.05.1
  * Updated the Russian and Italian translation.
- * Process the command line option --maxima=<str>.
+ * Process the command line option `--maxima=<str>`.
  * Resolved several possibilities to crash the config dialogue 
    (#1774, #1766)
  * Correctly calculate the worksheet size in the background (#1766)
@@ -302,5 +302,5 @@
  * A Russian translation update by OlesyaGerasimenko
  * Many small bugfixes including a crash on loading files with images.
 
-# Changes in older wxMaxima versions you can find here:
+# Changes in older wxMaxima versions you can find here
 <https://github.com/wxMaxima-developers/wxmaxima/blob/Version-21.02.0/NEWS.md>

locales/README.md

@@ -13,15 +13,16 @@ The subdirectories of this folder contain the translations of
 ### Translating wxMaxima to a new language
 
 In order to translate wxMaxima to a entirely new language two things have to be done:
- - Translate the .pot files to your language. If you don't want to translate
-   everything in one go that is completely fine: Quality is more important than
-   quantity here and getmessage is able to work with a partially-translated program
-   just fine; If the .pot files in the repository change whilst translation is
-   ongoing that is not the end of the world, neither: msgmerge will be able to
-   sort this out, too.
- - For Linux desktop integration additionally
-   data/io.github.wxmaxima_developers.wxMaxima.desktop needs to be equipped with
-   a translation.
+
+* Translate the .pot files to your language. If you don't want to translate
+  everything in one go that is completely fine: Quality is more important than
+  quantity here and getmessage is able to work with a partially-translated program
+  just fine; If the .pot files in the repository change whilst translation is
+* ongoing that is not the end of the world, neither: msgmerge will be able to
+  sort this out, too.
+* For Linux desktop integration additionally
+  data/io.github.wxmaxima_developers.wxMaxima.desktop needs to be equipped with
+  a translation.
 
 ### Improving an existing translation
 

src/ArtProvider.cpp

@@ -35,45 +35,45 @@
 
 wxBitmap ArtProvider::GetImage(wxWindow *win, wxString name, int width,
                                unsigned const char *data, std::size_t dataLen) {
-    wxBitmap bmp = wxArtProvider::GetBitmap(name, wxART_TOOLBAR,
-                                            wxSize(width * 4, width * 4));
-    wxImage img;
+  wxBitmap bmp = wxArtProvider::GetBitmap(name, wxART_TOOLBAR,
+                                          wxSize(width * 4, width * 4));
+  wxImage img;
 
-    if (bmp.IsOk()) {
-        img = bmp.ConvertToImage();
-    }
-    if (img.IsOk())
+  if (bmp.IsOk()) {
+    img = bmp.ConvertToImage();
+  }
+  if (img.IsOk())
     {
-        img.Rescale(width, width, wxIMAGE_QUALITY_BICUBIC);
+      img.Rescale(width, width, wxIMAGE_QUALITY_BICUBIC);
 #if defined __WXOSX__
-        int scaleFactor = win->GetContentScaleFactor();
-        if(scaleFactor < 1)
-            scaleFactor = 1;
-        if(scaleFactor > 16)
-            scaleFactor = 16;
+      int scaleFactor = win->GetContentScaleFactor();
+      if(scaleFactor < 1)
+        scaleFactor = 1;
+      if(scaleFactor > 16)
+        scaleFactor = 16;
 
-        bmp = wxBitmap(img, wxBITMAP_SCREEN_DEPTH, scaleFactor);
+      bmp = wxBitmap(img, wxBITMAP_SCREEN_DEPTH, scaleFactor);
 #else
-        bmp = wxBitmap(img, wxBITMAP_SCREEN_DEPTH);
+      bmp = wxBitmap(img, wxBITMAP_SCREEN_DEPTH);
 #endif
     }
-    if(!bmp.IsOk())
-        bmp = SvgBitmap(win, data, dataLen, width, width);
+  if(!bmp.IsOk())
+    bmp = SvgBitmap(win, data, dataLen, width, width);
 
 #if defined __WXOSX__
-    int scaleFactor = win->GetContentScaleFactor();
-    if(scaleFactor < 1)
-        scaleFactor = 1;
-    if(scaleFactor > 16)
-        scaleFactor = 16;
+  int scaleFactor = win->GetContentScaleFactor();
+  if(scaleFactor < 1)
+    scaleFactor = 1;
+  if(scaleFactor > 16)
+    scaleFactor = 16;
 #endif
 
-    if(!bmp.IsOk())
+  if(!bmp.IsOk())
 #if defined __WXOSX__
 
-        bmp = wxBitmap(wxSize(width, width), wxBITMAP_SCREEN_DEPTH, scaleFactor);
+    bmp = wxBitmap(wxSize(width, width), wxBITMAP_SCREEN_DEPTH, scaleFactor);
 #else
-    bmp = wxBitmap(wxSize(width, width), wxBITMAP_SCREEN_DEPTH);
+  bmp = wxBitmap(wxSize(width, width), wxBITMAP_SCREEN_DEPTH);
 #endif
-    return bmp;
+  return bmp;
 }