Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonSchemaDialect missing property and schema impacts #160

Open
cboitel opened this issue Jan 14, 2025 · 0 comments
Open

jsonSchemaDialect missing property and schema impacts #160

cboitel opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cboitel
Copy link

cboitel commented Jan 14, 2025

As per https://spec.openapis.org/oas/v3.1.1.html#fixed-fields, there is an optional property named jsonSchemaDialect.

On this one (and maybe others), one should be aware of the followings:

  1. it is optional and has a default
    • should the library return the default value if not provided ?
    • i think both should be possible (e.g. get vs get_or_default)
  2. $schema property in schema definitions is expected to match the jsonSchemaDialect unless a specific$schema is provided:
    • again, should the library return the default value if not provided ?
    • moreover, dialect/schema used impacts supported properties in schema struct: should the library report invalid schema definitions against the specified json schema definition used ?
@robjtede robjtede added the enhancement New feature or request label Jan 14, 2025
@robjtede robjtede self-assigned this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants