Skip to content

Conversation

@glehmann
Copy link
Member

No description provided.

@glehmann glehmann requested a review from a team as a code owner November 27, 2025 20:04
@glehmann glehmann force-pushed the gln/vdi-export-integrity branch 2 times, most recently from 230f06d to 9c9cc72 Compare November 28, 2025 10:08
@glehmann glehmann force-pushed the gln/xva-export-integrity branch from 04dc842 to 40b31bf Compare November 29, 2025 22:11
@glehmann glehmann force-pushed the gln/vdi-export-integrity branch from 9c9cc72 to 92c11bb Compare November 29, 2025 22:11
Copy link

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't duplicated code be factorized ? or this is not desired in context of pytests ?

https://en.wikipedia.org/wiki/Don%27t_repeat_yourself

@stormi
Copy link
Member

stormi commented Dec 1, 2025

Can't duplicated code be factorized ? or this is not desired in context of pytests ?

https://en.wikipedia.org/wiki/Don%27t_repeat_yourself

We do apply this principle in general, I don't know why not in this specific case, but I agree, we could definitely move the repeated code to a utility function, as we've done for live migration tests in the same storage test packages.

@glehmann
Copy link
Member Author

glehmann commented Dec 8, 2025

Can't duplicated code be factorized ? or this is not desired in context of pytests ?
en.wikipedia.org/wiki/Don%27t_repeat_yourself

We do apply this principle in general, I don't know why not in this specific case, but I agree, we could definitely move the repeated code to a utility function, as we've done for live migration tests in the same storage test packages.

It's just because at first there was a significant number of differences, but most of them are gone. I'll move it to a utility function

@glehmann glehmann force-pushed the gln/xva-export-integrity branch from 40b31bf to b0b5cde Compare December 9, 2025 08:21
@glehmann glehmann force-pushed the gln/vdi-export-integrity branch from 92c11bb to 5e92156 Compare December 9, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants