-
Notifications
You must be signed in to change notification settings - Fork 6
vdi export/import tests #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gln/xva-export-integrity
Are you sure you want to change the base?
Conversation
230f06d to
9c9cc72
Compare
04dc842 to
40b31bf
Compare
9c9cc72 to
92c11bb
Compare
rzr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't duplicated code be factorized ? or this is not desired in context of pytests ?
We do apply this principle in general, I don't know why not in this specific case, but I agree, we could definitely move the repeated code to a utility function, as we've done for live migration tests in the same storage test packages. |
It's just because at first there was a significant number of differences, but most of them are gone. I'll move it to a utility function |
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
40b31bf to
b0b5cde
Compare
92c11bb to
5e92156
Compare
No description provided.