Add support for VM serial/UART console logging #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce SerialConsoleLogger that captures serial console output from VMs using 'xl console -t serial' via background SSH processes. Features: - Background monitoring with automatic VM reboot/crash handling; domid tracking using UUID of the VM. - Logs to the same pytest-logs/ than reports gathered on failed tests. Also add unix_vm_with_serial_console fixture that configures Linux VMs to output kernel logs to serial console by modifying bootloader configs (GRUB/extlinux) for supported distributions. Signed-off-by: Emmanuel Varagnat <[email protected]>
Create VM class hierarchy to support distribution-specific
functionality:
VM → UnixVM → {AlpineVM, AlmaVM, CentOSVM, DebianVM, OpenSuseVM,
UbuntuVM, FreeBSD}
VM → WindowsVM
Each distro class implements configure_serial_console() for its specific
bootloader configuration.
UnixVM provides class methods for auto-detection and conversion:
- detect_distro(vm): Detect distro from /etc/os-release
- get_distro_class(distro): Map distro ID to VM subclass
- from_vm_auto_detect(vm): Auto-detect and convert in one call
More VM refactoring to come...
Signed-off-by: Emmanuel Varagnat <[email protected]>
Member
|
Since it's still a draft, with a few unknowns, I suggest a "live" discussion/review with the interested parties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #364 witch was accidentally closed; marked as merged by Github because of a force push.
To debug or just understand why a test failed it could be interesting to have more logs from the VM.
For instance, sometimes tests failed because a VM isn't able to get an IP in the time limit of test.
Using unix_vm_with_serial_console fixture, a test can ask to log serial output for a VM (Unix in this case, or could be Linux instead).
The fixture also ensure that the serial output is enabled by modifying the kernel command-line, because for the moment images we are importing for the tests don't have the console enabled.
This is debatable, but at least for now we try this patch set without modifying any of the current images.
The branch is on top
eva/log-test-failure(#362) and ideally would also require that brancheva/local-cmd-generalize(#359) be merged also.That's why the PR is not on top
master.Windows not supported (yet?). VM type (Unix or Windows) depends on test.
Distro classes only implement the console configuration and is specific to bootloader, but should move more methods from VM to UnixVM or WindowsVM.
Tested with:
With the following VMs on a XCP-ng 8.3 :
Not tested: