Refactorings, tidy ups

Author: xeolabs

packages/sdk/src/convert/xeoconvert/xeoconvert_core.cjs.js

@@ -175585,7 +175585,7 @@ var FixRegistry = class {
 };
 _byCode = new WeakMap();
 
-// src/demo/synthesizeGeometryAttribs.ts
+// src/studio/synthesizeGeometryAttribs.ts
 function generateSmoothNormals(positionsCompressed, indices, aabb) {
   const vertCount = positionsCompressed.length / 3 | 0;
   const triCount = indices.length / 3 | 0;
@@ -176459,7 +176459,7 @@ function aabbDiagonal(aabb) {
   return Math.sqrt(dx * dx + dy * dy + dz * dz);
 }
 
-// src/demo/splitSceneGeometry.ts
+// src/studio/splitSceneGeometry.ts
 function splitSceneGeometry(params) {
   var _a2, _b;
   const src = params.sceneGeometry;

packages/sdk/src/model/data/DataTraversalQuery.ts

@@ -1,4 +1,10 @@
-// model/ — auto-generated bucket index.
+/**
+ * The **scene graph** (3D geometry, materials, objects) and the **data graph** (semantic entities, relationships,
+ * property sets). Both are renderer-agnostic and run identically in the browser and Node. Streaming and procedural
+ * authoring live here too.
+ *
+ * @submodule model
+ */
 export * as data from "./data";
 export * as procgen from "./procgen";
 export * as scene from "./scene";

packages/sdk/src/model/index.ts

@@ -82,13 +82,6 @@ export function paintStudio(
   if (drawSun) {
     const sx = width * 0.18, sy = height * 0.20;
     const sRadius = Math.min(width, height) * 0.04;
-    const glowRadius = sRadius * 4.0;
-    const glow = ctx.createRadialGradient(sx, sy, 0, sx, sy, glowRadius);
-    glow.addColorStop(0,   "rgba(255,245,210,0.85)");
-    glow.addColorStop(0.4, "rgba(255,235,180,0.30)");
-    glow.addColorStop(1,   "rgba(255,235,180,0.00)");
-    ctx.fillStyle = glow;
-    ctx.beginPath(); ctx.arc(sx, sy, glowRadius, 0, Math.PI * 2); ctx.fill();
     ctx.fillStyle = "rgb(255,250,235)";
     ctx.beginPath(); ctx.arc(sx, sy, sRadius, 0, Math.PI * 2); ctx.fill();
   }
@@ -105,12 +98,6 @@ export function paintStudio(
     for (const sb of softboxes) {
       const x = sb.u * width, y = sb.v * height;
       const w = sb.w * width, h = sb.h * height;
-      const halo = ctx.createRadialGradient(x + w * 0.5, y + h * 0.5, 0,
-                                            x + w * 0.5, y + h * 0.5, w * 0.85);
-      halo.addColorStop(0, sb.tint.replace("rgb", "rgba").replace(")", ",0.55)"));
-      halo.addColorStop(1, sb.tint.replace("rgb", "rgba").replace(")", ",0.00)"));
-      ctx.fillStyle = halo;
-      ctx.fillRect(x - w * 0.4, y - h * 1.5, w * 1.8, h * 4.0);
       ctx.fillStyle = sb.tint;
       ctx.fillRect(x, y, w, h);
     }

packages/sdk/src/model/procgen/paintEnvironments/paintStudio.ts

@@ -55,7 +55,7 @@ export interface PaintWoodPlankOptions {
  *
  * Orientation on rendered surfaces depends on how the surface's UVs
  * were generated. The planar projection used by
- * {@link demo!attachSceneModelMaterials | attachSceneModelMaterials}
+ * {@link studio!attachSceneModelMaterials | attachSceneModelMaterials}
  * aligns V with world vertical on wall-like geometries, so this
  * painter renders vertical planks on every wall. Non-metal.
  */

packages/sdk/src/model/procgen/paintMaterials/paintWoodPlank.ts

@@ -579,8 +579,12 @@ export class SceneTransform {
       this._parentTransform._updateGlobal(force);
       mulMat4(this._parentTransform._worldMatrix, this._localMatrix, this._worldMatrix);
     } else {
-      // @ts-ignore
-      this._worldMatrix.set(this._localMatrix);
+      // Root transform — apply the SceneModel's coord-system pre-multiply,
+      // same as the `get worldMatrix()` getter. Previously this branch
+      // copied the local matrix directly, which produced a wrong world
+      // matrix for any reparenting/preserveWorld path on a model whose
+      // basis differed from the scene's.
+      mulMat4(this.model.coordinateSystemMatrix, this._localMatrix, this._worldMatrix);
     }
     this._worldMatrixDirty = false;
 

packages/sdk/src/model/scene/SceneTransform.ts

@@ -48,11 +48,22 @@ export function compressGeometryParams(geometryParams: SceneGeometryParams): Sce
       origin: rtcNeeded ? rtcCenter : null
     };
   } else {
-    const edgeIndices = (geometryParams.primitive === SolidPrimitive
+    // For triangle-family geometries, auto-build feature edges. The
+    // builder returns an EMPTY typed array when every interior edge
+    // is too smooth to count (typical of a single fully-coplanar
+    // tessellation — e.g. an earcut'd 2D polygon at z=0, which is
+    // common in drawing/SVG/PDF imports) AND every triangle's edge
+    // is shared with a neighbour. Collapse that to `null` so
+    // downstream consumers (specifically the WebGLRenderer's edge
+    // portion allocator, which rejects size=0) see "no edges" as a
+    // first-class state rather than an empty buffer to upload.
+    let edgeIndices: ReturnType<typeof buildEdgeIndices> | null = null;
+    if ((geometryParams.primitive === SolidPrimitive
       || geometryParams.primitive === SurfacePrimitive
-      || geometryParams.primitive === TrianglesPrimitive) && geometryParams.indices
-      ? buildEdgeIndices(positionsCompressed, geometryParams.indices, aabb, 10)
-      : null;
+      || geometryParams.primitive === TrianglesPrimitive) && geometryParams.indices) {
+      const built = buildEdgeIndices(positionsCompressed, geometryParams.indices, aabb, 10);
+      if (built && built.length > 0) edgeIndices = built;
+    }
     // Encode normals only when supplied and length-matched against positions.
     const normalsCompressed =
       geometryParams.normals && geometryParams.normals.length === geometryParams.positions.length

packages/sdk/src/model/scene/compressGeometryParams.ts

@@ -11,12 +11,11 @@ import type {SceneObject} from "./SceneObject";
  * proxies, NavCube), user annotations, comparison snapshots,
  * etc.
  *
- * Studio panels that list "the SceneModels the user authored"
- * — SceneHealthPanel's tab strip, SchemaMaterialsPanel's tab
- * strip, DrawingsPanel's source-model picker, and any other
- * user-facing enumerator — call {@link isDefaultLayerModel} to
- * whitelist the default layer. Anything in a named layer is
- * skipped, regardless of name.
+ * Enumerators that list "the SceneModels the user authored" —
+ * user-facing tab strips, source-model pickers, inspection
+ * walkers — call {@link isDefaultLayerModel} to whitelist the
+ * default layer. Anything in a named layer is skipped, regardless
+ * of name.
  *
  * Consumption-side only — the renderer's draw, pick, and clip
  * paths see every layer normally.

packages/sdk/src/model/scene/isDefaultLayer.ts

@@ -0,0 +1,21 @@
+import type {CameraTourPlanOptions} from "../plan/CameraTourPlanOptions";
+import type {SpaceGraph} from "../graph/SpaceGraph";
+import type {ViewpointGraph} from "../graph/ViewpointGraph";
+import type {TourStop} from "../planners/TourPlanner";
+
+
+/**
+ * Inputs to {@link buildTourWaypoints}.
+ *
+ * @internal
+ */
+export interface BuildTourWaypointsInput {
+  stops: ReadonlyArray<TourStop>;
+  spaceGraph: SpaceGraph;
+  viewpointGraph: ViewpointGraph;
+  /** Resolved options — every field used here is required. */
+  options: Required<Pick<CameraTourPlanOptions,
+      "eyeHeight" | "dwellMs" | "flightDurationMs">>;
+  /** World up — looked up from the source scene when not overridden. */
+  up: [number, number, number];
+}

packages/sdk/src/presentations/cameraTour/build/BuildTourWaypointsInput.ts

@@ -0,0 +1,13 @@
+import type {CameraTourWaypoint} from "../plan/CameraTourWaypoint";
+
+
+/**
+ * Output of {@link buildTourWaypoints}.
+ *
+ * @internal
+ */
+export interface BuildTourWaypointsResult {
+  waypoints: ReadonlyArray<CameraTourWaypoint>;
+  /** Sum of all dwellMs + flightDurationMs across consecutive waypoints. */
+  estimatedDurationMs: number;
+}