Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLF4J still required in release 3.47.0.0 #1203

Closed
rmraya opened this issue Oct 23, 2024 · 1 comment
Closed

SLF4J still required in release 3.47.0.0 #1203

rmraya opened this issue Oct 23, 2024 · 1 comment
Labels

Comments

@rmraya
Copy link
Contributor

rmraya commented Oct 23, 2024

Describe the bug
SLF4J is still marked as required in release 3.47.0.0, although it should be optional according to the Release Notes for 3.46.1.1

To Reproduce
Running jlink in a project that uses sqlite-jdbc without slf4j jars in the classpath result in this error:

jlink failed (exit code 1), output is: Error: Module org.slf4j not found, required by org.xerial.sqlitejdbc
java.lang.module.FindException: Module org.slf4j not found, required by org.xerial.sqlitejdbc

Expected behavior
jlink should be able to link the project without requiring org.slf4j

Logs
If applicable, provide logs.

Environment (please complete the following information):

  • OS: macOS, Windows and Linux
  • CPU architecture: x86_64 and arm64
  • Java version: 21.0.5
  • sqlite-jdbc version 3.47.0.0

Additional context
org.slf4j is marked as required in src/main/java9/module-info.java

@rmraya rmraya added the triage label Oct 23, 2024
@rmraya
Copy link
Contributor Author

rmraya commented Oct 24, 2024

This issue is fixed in latest snapshot that incorporated PR #1205

@rmraya rmraya closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant