Improve Error Handling in Portfolio example chart panels (#701)

Fixes #695 

---------

Co-authored-by: Jacob Haddad <[email protected]>

Author: jacob-xhio

client-app/src/examples/portfolio/detail/charts/LineChart.ts

@@ -3,10 +3,14 @@ import {creates, hoistCmp, HoistModel, lookup, managed, XH} from '@xh/hoist/core
 import {fmtDate} from '@xh/hoist/format';
 import {ChartsPanelModel} from './ChartsPanelModel';
 import {panel} from '@xh/hoist/desktop/cmp/panel';
+import {errorMessage} from '@xh/hoist/dynamics/desktop';
 
 export const lineChart = hoistCmp.factory({
     model: creates(() => LineChartModel),
-    render() {
+    render({model}) {
+        if (model.lastLoadException) {
+            return errorMessage({error: model.lastLoadException});
+        }
         return panel({
             item: chart(),
             mask: 'onLoad',
@@ -70,13 +74,14 @@ class LineChartModel extends HoistModel {
 
         try {
             const series = await XH.portfolioService.getLineChartSeriesAsync({symbol, loadSpec});
-
-            if (!loadSpec.isObsolete) {
+            if (!loadSpec.isStale) {
                 chartModel.setSeries(series);
             }
         } catch (e) {
+            if (loadSpec.isAutoRefresh || loadSpec.isStale) return;
             chartModel.clear();
-            XH.handleException(e);
+            XH.handleException(e, {showAlert: false});
+            throw e;
         }
     }
 }

client-app/src/examples/portfolio/detail/charts/OHLCChart.ts

@@ -3,10 +3,14 @@ import {creates, hoistCmp, HoistModel, lookup, managed, XH} from '@xh/hoist/core
 import {fmtDate, fmtPrice} from '@xh/hoist/format';
 import {ChartsPanelModel} from './ChartsPanelModel';
 import {panel} from '@xh/hoist/desktop/cmp/panel';
+import {errorMessage} from '@xh/hoist/dynamics/desktop';
 
 export const ohlcChart = hoistCmp.factory({
     model: creates(() => OHLCChartModel),
-    render() {
+    render({model}) {
+        if (model.lastLoadException) {
+            return errorMessage({error: model.lastLoadException});
+        }
         return panel({
             item: chart(),
             mask: 'onLoad',
@@ -88,12 +92,14 @@ class OHLCChartModel extends HoistModel {
 
         try {
             const series = await XH.portfolioService.getOHLCChartSeriesAsync({symbol, loadSpec});
-            if (!loadSpec.isObsolete) {
+            if (!loadSpec.isStale) {
                 chartModel.setSeries(series);
             }
         } catch (e) {
+            if (loadSpec.isAutoRefresh || loadSpec.isStale) return;
             chartModel.clear();
-            XH.handleException(e);
+            XH.handleException(e, {showAlert: false});
+            throw e;
         }
     }
 }

grails-app/controllers/io/xh/toolbox/portfolio/PortfolioController.groovy

@@ -1,5 +1,6 @@
 package io.xh.toolbox.portfolio
 
+import io.xh.hoist.exception.DataNotAvailableException
 import io.xh.hoist.security.AccessAll
 import io.xh.toolbox.BaseController
 
@@ -48,6 +49,9 @@ class PortfolioController extends BaseController {
     // List of MarketPrices for the given instrument identified by its symbol
     def prices() {
         List<MarketPrice> historicalPrices = portfolioService.getData().historicalPrices[params.id]
+        if (!historicalPrices) {
+            throw new DataNotAvailableException("No historical prices available for ${params.id}")
+        }
         MarketPrice intradayPrices = portfolioService.getData().intradayPrices[params.id]
         List<MarketPrice> allPrices = intradayPrices ? historicalPrices.dropRight(1)+[intradayPrices] : historicalPrices
         renderJSON(allPrices)