Error for deleted files in "Open Recent"

[scholtzan]

If a previously opened file gets deleted, then xi mac prints the following error on startup when trying to add the file to "Open Recent":

2018-10-02 09:01:55.161649-0700 XiEditor[53225:1802279] [default] Failed to updated bookmark for item (null) [CFBFD760-28E1-4D5D-91C0-41B6262D0BED] - URL:file:///path/to/deleted/file.txt with error Error 

Also, the entry for deleted files still exists in "Open Recent" but is empty (no file name). I think it would be better to not have entries for deleted files?

[jkaan]

@cmyr I would like to start with this one, probably this is a good one to get started with and later I can pick up #275

[mmatoszko]

I did some digging and this is not as straighforward as it seems :)

Recent documents functionality is provided out of the box by NSDocumentController.

It is possible to get the recent documents list using recentDocumentURLs property on NSDocumentController, so we could in theory write our own implementation of the list using this property and filter out the non-existent files.

It seems like an easy task to do, but considering the fact that we're going to remove NSDocument in the near future (see #290) I'm not sure it's worth the effort.

[cmyr]

What surprises me here is that NSDocument doesn't handle the filtering of non-existent files; I sort of suspect that it does by default (this should be easy to test?) but maybe we're disabling it somehow?

In any case, I agree it doesn't make much sense to do a bunch of work on this if we're going to throw it away. That said, maybe it's worth starting a list somewhere of the various features we're going to need to reimplement when we do move off of NSDocument?