Merge pull request #171 from xmtp/cv/mutable-metadata-mapping

cameronvoell · web-flow · commit 2cae00e94248 · 2024-04-22T16:45:44.000-07:00
feat: update group mutable metadata to use map for upgradability
diff --git a/proto/mls/database/intents.proto b/proto/mls/database/intents.proto
@@ -65,7 +65,8 @@ message RemoveMembersData {
 message UpdateMetadataData {
   // V1 of UpdateMetadataPublishData
   message V1 {
-    string group_name = 1;
+    string field_name = 1;
+    string field_value = 2;
   }
 
   oneof version {
diff --git a/proto/mls/message_contents/group_metadata.proto b/proto/mls/message_contents/group_metadata.proto
@@ -24,7 +24,7 @@ enum ConversationType {
 message PolicySet {
   MembershipPolicy add_member_policy = 1;
   MembershipPolicy remove_member_policy = 2;
-  MetadataPolicy update_group_name_policy = 3;
+  map<string, MetadataPolicy> update_metadata_policy = 3;
 }
 
 // A policy that governs adding/removing members or installations
diff --git a/proto/mls/message_contents/group_mutable_metadata.proto b/proto/mls/message_contents/group_mutable_metadata.proto
@@ -8,5 +8,5 @@ option java_package = "org.xmtp.proto.mls.message.contents";
 
 // Message for group mutable metadata
 message GroupMutableMetadataV1 {
-  string group_name = 1;
+  map<string, string> attributes = 1;  // Map to store various metadata attributes
 }

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,8 @@ message RemoveMembersData {`
`65`	`65`	`message UpdateMetadataData {`
`66`	`66`	`// V1 of UpdateMetadataPublishData`
`67`	`67`	`message V1 {`
`68`		`- string group_name = 1;`
	`68`	`+ string field_name = 1;`
	`69`	`+ string field_value = 2;`
`69`	`70`	`}`
`70`	`71`
`71`	`72`	`oneof version {`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ enum ConversationType {`
`24`	`24`	`message PolicySet {`
`25`	`25`	`MembershipPolicy add_member_policy = 1;`
`26`	`26`	`MembershipPolicy remove_member_policy = 2;`
`27`		`- MetadataPolicy update_group_name_policy = 3;`
	`27`	`+ map<string, MetadataPolicy> update_metadata_policy = 3;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`// A policy that governs adding/removing members or installations`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,5 @@ option java_package = "org.xmtp.proto.mls.message.contents";`
`8`	`8`
`9`	`9`	`// Message for group mutable metadata`
`10`	`10`	`message GroupMutableMetadataV1 {`
`11`		`- string group_name = 1;`
	`11`	`+ map<string, string> attributes = 1; // Map to store various metadata attributes`
`12`	`12`	`}`