#215: temporarily remove --system

xpack · Dec 9, 2024 · 0c8b9a6 · 0c8b9a6
1 parent c072af8
commit 0c8b9a6
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 41 deletions.
diff --git a/lib/xpm/install.js b/lib/xpm/install.js
@@ -116,17 +116,17 @@ export class Install extends CliCommand {
             msg: 'Install the package globally in the home folder',
             isOptional: true
           },
-          {
-            options: ['-sy', '--system'],
-            init: ({ config }) => {
-              config.isSystem = false
-            },
-            action: ({ config }) => {
-              config.isSystem = true
-            },
-            msg: 'Install the package in a system folder',
-            isOptional: true
-          },
+          // {
+          //   options: ['-sy', '--system'],
+          //   init: ({ config }) => {
+          //     config.isSystem = false
+          //   },
+          //   action: ({ config }) => {
+          //     config.isSystem = true
+          //   },
+          //   msg: 'Install the package in a system folder',
+          //   isOptional: true
+          // },
           {
             options: ['-f', '--force'],
             init: ({ config }) => {

diff --git a/lib/xpm/list.js b/lib/xpm/list.js
@@ -92,17 +92,17 @@ export class List extends CliCommand {
             msg: 'List the global package(s)',
             isOptional: true
           },
-          {
-            options: ['-sy', '--system'],
-            init: ({ config }) => {
-              config.isSystem = false
-            },
-            action: ({ config }) => {
-              config.isSystem = true
-            },
-            msg: 'List the system package(s) (not impl)',
-            isOptional: true
-          },
+          // {
+          //   options: ['-sy', '--system'],
+          //   init: ({ config }) => {
+          //     config.isSystem = false
+          //   },
+          //   action: ({ config }) => {
+          //     config.isSystem = true
+          //   },
+          //   msg: 'List the system package(s) (not impl)',
+          //   isOptional: true
+          // },
           {
             options: ['-c', '--config'],
             init: ({ config }) => {

diff --git a/lib/xpm/uninstall.js b/lib/xpm/uninstall.js
@@ -95,17 +95,17 @@ export class Uninstall extends CliCommand {
             msg: 'Uninstall the global package(s)',
             isOptional: true
           },
-          {
-            options: ['-sy', '--system'],
-            init: ({ config }) => {
-              config.isSystem = false
-            },
-            action: ({ config }) => {
-              config.isSystem = true
-            },
-            msg: 'Uninstall the system package(s) (not impl)',
-            isOptional: true
-          },
+          // {
+          //   options: ['-sy', '--system'],
+          //   init: ({ config }) => {
+          //     config.isSystem = false
+          //   },
+          //   action: ({ config }) => {
+          //     config.isSystem = true
+          //   },
+          //   msg: 'Uninstall the system package(s) (not impl)',
+          //   isOptional: true
+          // },
           {
             options: ['-c', '--config'],
             init: ({ config }) => {

diff --git a/tests/tap/530-xpm-install.js b/tests/tap/530-xpm-install.js
@@ -59,15 +59,14 @@ test('xpm install -h',
         // console.log(outLines)
         t.match(outLines[1], 'install package(s)', 'has title')
         t.match(outLines[2], 'Usage: xpm install [options...] ' +
-          '[--global] [--system] [--force]', 'has Usage')
+          '[--global] [--force]', 'has Usage')
         t.match(outLines[8], 'Install options:', 'has install options')
         t.match(outLines[9], '  -g|--global  ', 'has --global')
-        t.match(outLines[10], '  -sy|--system  ', 'has --system')
-        t.match(outLines[11], '  -f|--force  ', 'has --force')
-        t.match(outLines[12], '  -32|--force-32bit ', 'has --force-32bit')
-        t.match(outLines[13], '  -c|--config <config_name>  ', 'has --config')
-        t.match(outLines[14], '  -a|--all-configs  ')
-        t.match(outLines[15], '  -n|--dry-run  ', 'has --dry-run')
+        t.match(outLines[10], '  -f|--force  ', 'has --force')
+        t.match(outLines[11], '  -32|--force-32bit ', 'has --force-32bit')
+        t.match(outLines[12], '  -c|--config <config_name>  ', 'has --config')
+        t.match(outLines[13], '  -a|--all-configs  ')
+        t.match(outLines[14], '  -n|--dry-run  ', 'has --dry-run')
       }
       // There should be no error messages.
       t.equal(stderr, '', 'stderr is empty')
@@ -95,7 +94,7 @@ test('xpm instal -h',
         // console.log(outLines)
         t.match(outLines[1], 'install package(s)', 'has title')
         t.match(outLines[2], 'Usage: xpm install [options...] ' +
-          '[--global] [--system] [--force]', 'has Usage')
+          '[--global] [--force]', 'has Usage')
       }
       // There should be no error messages.
       t.equal(stderr, '', 'stderr is empty')