#218: fix makeDirectory for link

xpack · Dec 10, 2024 · d2336ec · d2336ec
1 parent 080f97d
commit d2336ec
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -907,6 +907,35 @@
       "console": "internalConsole",
       "sourceMaps": false
     },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "xpm link @scope/name",
+      "program": "${workspaceRoot}/bin/xpm.js",
+      "stopOnEntry": true,
+      "args": [
+        "link",
+        "@xpack-dev-tools/xbb-helper",
+        "-dd",
+        "-C",
+        "/Users/ilg/tmp/tolink"
+      ],
+      "cwd": "${workspaceRoot}",
+      "preLaunchTask": null,
+      "runtimeExecutable": null,
+      "runtimeArgs": [
+        "--nolazy"
+      ],
+      "skipFiles": [
+        "async_hooks.js",
+        "inspector_async_hook.js"
+      ],
+      "env": {
+        "NODE_ENV": "development"
+      },
+      "console": "internalConsole",
+      "sourceMaps": false
+    },
     {
       "type": "node",
       "request": "launch",

diff --git a/lib/xpm/link.js b/lib/xpm/link.js
@@ -207,7 +207,7 @@ export class Link extends CliCommand {
     }
 
     // Create parent folder, for just in case.
-    await makeDirectory(globalPackagePath)
+    await makeDirectory(path.dirname(globalPackageLinkPath))
 
     // fs.symlink(target, path[, type], callback)
     // 'creates the link called path pointing to target'
@@ -368,7 +368,7 @@ export class Link extends CliCommand {
       }
 
       // Create parent folder, for just in case.
-      await makeDirectory(localXpacksFolderPath)
+      await makeDirectory(path.dirname(localXpacksLinkPath))
 
       // fs.symlink(target, path[, type], callback)
       // 'creates the link called path pointing to target'