Check for long lines

Author: xrd

lib/oreilly/snippets.rb

@@ -111,6 +111,15 @@ def self.process_callouts( input, callouts, comment_character = nil )
         end
         rv = lines.join "\n"
       end
+
+      if ENV['OREILLY_SNIPPETS_DEBUG_LONG_LINES']
+        rv.split( /\n/ ).each_with_index do |l,i|
+          if l.length > 70
+            raise "Line #{i+1} is too long: #{l.length} characters long"
+          end
+        end
+      end
+
       rv
     end
 

spec/fixtures/really_long_line.rb

@@ -0,0 +1 @@
+abc def abc def abc def abc def abc def abc def abc def abc def abc def abc def abc def 

spec/process_spec.rb

@@ -13,6 +13,13 @@
 snippet~~~~
 END
 
+LONG_LINES = <<END
+[filename="../spec/fixtures/really_long_lines.rb"]
+snippet~~~~
+Put any descriptive text you want here. It will be replaced with the
+snippet~~~~
+END
+
 
 WITH_SHA = <<END
 [filename="#{ROOT}", language="js", sha="c863f786f5959799d7c:test.js"]
@@ -322,6 +329,15 @@ def download_test_repository
       end
     end
 
+    describe "#warnlonglines" do
+      it "should warn you if there is a really long line of code" do
+        ENV['OREILLY_SNIPPETS_DEBUG_LONG_LINES'] = "1"
+        lambda {
+          Oreilly::Snippets.process( LONG_LINES )
+        }.should raise_error
+      end
+    end
+
     describe "#flatten" do
       before( :each ) do
         @with_spaces = File.read( "spec/fixtures/with_spaces.rb" )