Skip to content

Commit 358d9fe

Browse files
committed
fix(http): 修复 HttpTool 类中潜在的资源泄漏问题
1 parent f8f8ae9 commit 358d9fe

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/main/java/com/xxl/tool/http/HttpTool.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ private static String doRequest(String method,
7272
int timeout) {
7373

7474
HttpURLConnection connection = null;
75+
DataOutputStream dataOutputStream = null;
7576
BufferedReader bufferedReader = null;
7677
try {
7778
// connection
@@ -108,7 +109,7 @@ private static String doRequest(String method,
108109

109110
// write requestBody
110111
if (StringTool.isNotBlank(requestBody)) {
111-
DataOutputStream dataOutputStream = new DataOutputStream(connection.getOutputStream());
112+
dataOutputStream = new DataOutputStream(connection.getOutputStream());
112113
dataOutputStream.write(requestBody.getBytes(StandardCharsets.UTF_8));
113114
dataOutputStream.flush();
114115
dataOutputStream.close();
@@ -135,6 +136,9 @@ private static String doRequest(String method,
135136
throw new RuntimeException("Http Request Error ("+ e.getMessage() +"). for url : " + url);
136137
} finally {
137138
try {
139+
if (dataOutputStream != null) {
140+
dataOutputStream.close();
141+
}
138142
if (bufferedReader != null) {
139143
bufferedReader.close();
140144
}

0 commit comments

Comments
 (0)