Skip to content

Commit 6938bd7

Browse files
authored
Example apps improvements (software-mansion#4308)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR: * fixes WithoutBabelPluginExample when used in WebExample with `DISABLE_BABEL_PLUGIN=1` * adds missing definition of `_REANIMATED_VERSION_BABEL_PLUGIN` in `globals.d.ts` * add `--max-warnings=0` flag for ESLint * adds ESLint and Prettier in WebExample and TVOSExample * adds CI check for WebExample and TVOSExample ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
1 parent d62a6bf commit 6938bd7

15 files changed

+745
-369
lines changed

.github/workflows/static-example-apps-checks.yml

+8-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ on:
33
pull_request:
44
paths:
55
- '.github/workflows/static-example-apps-checks.yml'
6+
- 'app/**'
67
- 'Example/**'
78
- 'FabricExample/**'
9+
- 'WebExample/**'
10+
- 'TVOSExample/**'
811
- '*'
912
merge_group:
1013
branches:
@@ -17,7 +20,7 @@ jobs:
1720
runs-on: ubuntu-latest
1821
strategy:
1922
matrix:
20-
working-directory: [Example, FabricExample]
23+
working-directory: [app, Example, FabricExample, WebExample, TVOSExample]
2124
concurrency:
2225
group: typescript-${{ matrix.working-directory }}-${{ github.ref }}
2326
cancel-in-progress: true
@@ -40,3 +43,7 @@ jobs:
4043
- name: Lint
4144
working-directory: ${{ matrix.working-directory }}
4245
run: yarn lint
46+
- name: Build
47+
working-directory: ${{ matrix.working-directory }}
48+
if: ${{ matrix.working-directory == 'WebExample' }}
49+
run: yarn build

.github/workflows/validate-app.yml

-37
This file was deleted.

Example/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"scripts": {
66
"android": "react-native run-android",
77
"ios": "react-native run-ios",
8-
"lint": "eslint .",
8+
"lint": "eslint --max-warnings=0 .",
99
"start": "react-native start",
1010
"test": "jest",
1111
"postinstall": "patch-package"

FabricExample/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"scripts": {
66
"android": "react-native run-android",
77
"ios": "react-native run-ios",
8-
"lint": "eslint .",
8+
"lint": "eslint --max-warnings=0 .",
99
"start": "react-native start",
1010
"test": "jest",
1111
"postinstall": "patch-package"

TVOSExample/package.json

+7-5
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
"android": "react-native run-android",
77
"ios": "react-native run-ios",
88
"tvos": "react-native run-ios --scheme=\"TVOSExample-tvOS\" --simulator=\"Apple TV\"",
9+
"lint": "eslint --max-warnings=0 .",
910
"start": "react-native start",
10-
"test": "jest",
11-
"lint": "eslint ."
11+
"test": "jest"
1212
},
1313
"dependencies": {
1414
"react": "18.0.0",
@@ -18,12 +18,14 @@
1818
"devDependencies": {
1919
"@babel/core": "^7.12.9",
2020
"@babel/runtime": "^7.12.5",
21-
"@react-native-community/eslint-config": "^2.0.0",
21+
"@react-native-community/eslint-config": "^3.2.0",
2222
"babel-jest": "^26.6.3",
23-
"eslint": "^7.32.0",
23+
"eslint": "^8.19.0",
2424
"jest": "^26.6.3",
2525
"metro-react-native-babel-preset": "^0.70.3",
26-
"react-test-renderer": "18.0.0"
26+
"prettier": "^2.6.1",
27+
"react-test-renderer": "18.0.0",
28+
"typescript": "^4.8.4"
2729
},
2830
"jest": {
2931
"preset": "react-native"

0 commit comments

Comments
 (0)