Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v9 support #200

Open
l3ender opened this issue Jul 20, 2024 · 3 comments
Open

ESLint v9 support #200

l3ender opened this issue Jul 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@l3ender
Copy link

l3ender commented Jul 20, 2024

Hello, are there plans to update the plugin to support ESLint v9? Thanks!

https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

@yeonjuan yeonjuan added the enhancement New feature or request label Jul 23, 2024
@yeonjuan
Copy link
Owner

yeonjuan commented Jul 23, 2024

Hi , @l3ender
Let me investigate what we need to do to update to v9 👍 Thanks

@yeonjuan
Copy link
Owner

Hi @l3ender
It looks like a breaking change affecting our plugin is planned for v10.0.0. So it should work fine in v9, let us know if you have any issues. Of course, we need to replace the depreacted methods for v10 support.

https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context-methods-becoming-properties

We are deprecating the methods in favor of the properties (added in v8.40.0). These methods will be removed in v10.0.0 (not v9.0.0) as they are not blocking language plugins work. Here’s an example that ensures the correct value is used:

@tlabeeuw
Copy link

Looks like the type in: packages/eslint-plugin/lib/index.js#L5-7 is referencing a deprecated type see types/eslint/index.d.ts#L1280-L1281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants