-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: minimal diff #582
Comments
This is syntatic diff you are suggesting. I think that in the context of code it is better to dump the whole thing. What we can do is to have a semantic diff support, but seems like too much work atm :)) |
Can I make a PR to add it as an option? Just find lines that are the same in both sections and delete them? |
Maybe just stripping duplicates off the ends of the block to avoid turning one block into multiple |
I've had a go at making it. Seems to work from my testing CREATE TABLE serbian_scores (
id INTEGER PRIMARY KEY AUTOINCREMENT,
user_id INTEGER,
test_id INTEGER,
FOREIGN KEY (user_id) REFERENCES users(id)
<<<<<<< HEAD
ON DELETE CASCADE
=======
ON DELETE CASCADE,
FOREIGN KEY (test_id) REFERENCES serbian_tests(id)
ON DELETE CASCADE
>>>>>>> Snippet
); |
The indentation doesn't seem correct? |
Yeah. Something is defo wrong. I'll investigate and update in the PR |
Perhaps it's better to have the smallest replacement when returning in the llm uplift prompt? |
Feature request
The LLMs tend to suggest replacement of large blocks of code, even when most of the block is unchanged. This makes it harder to review the changes it wants to make. Would it be possible to generate a minimal diff and apply that inside the merge conflict markers instead?
Example: This is generated
But it could just be
Motivation
No response
Other
No response
The text was updated successfully, but these errors were encountered: