feat: Node js 24 and v8 compatibility fixes (#357)

* fix(NaN): SetAccessors should use NAN_GETTER

* fix(addOn): sprintf is deprecated

* fix: update dependencies

* feat: add support for Node.js 24

* add changelog

Author: DavidVujic

CHANGELOG.md

@@ -1,3 +1,8 @@
+#### v 7.1.0 (2025-11-15)
+* feat: Node js 24 and v8 compatibility fixes
+
+  Pull request [357](https://github.com/yfinkelstein/node-zookeeper/pull/357) by @davidvujic
+
 #### v 7.0.0 (2025-05-25)
 * fix: enable workers
 

package.json

@@ -1,7 +1,7 @@
 {
     "name": "zookeeper",
     "description": "apache zookeeper client (zookeeper async API v3.5.x - v3.8.x)",
-    "version": "7.0.0",
+    "version": "7.1.0",
     "author": "Yuri Finkelstein <yurif2003@yahoo.com>",
     "license": "MIT",
     "contributors": [
@@ -34,17 +34,17 @@
         "decompress-targz": "4.1.x",
         "nan": "2.x",
         "node-gyp-build": "^4.2.3",
-        "shelljs": "0.8.x"
+        "shelljs": "0.10.x"
     },
     "devDependencies": {
-        "@types/node": "17.x",
-        "ava": "4.0.1",
+        "@types/node": "24.x",
+        "ava": "6.x",
         "eslint": "8.x",
         "eslint-config-airbnb-base": "15.x",
         "eslint-plugin-import": "2.x",
-        "prebuildify": "5.0.0",
-        "sinon": "12.x",
-        "typescript": "^4.0.5"
+        "prebuildify": "6.0.1",
+        "sinon": "21.x",
+        "typescript": "5.x"
     },
     "main": "./lib/index.js",
     "scripts": {

src/node-zk.cpp

@@ -66,7 +66,6 @@ namespace zk {
 #else
 	#define ZERO_MEM(member) bzero(&(member), sizeof(member))
 #endif
-#define _LL_CAST_ (long long)
 #define _LLP_CAST_ (long long *)
 
 #define THROW_IF_NOT(condition, text) if (!(condition)) { \
@@ -514,7 +513,7 @@ class ZooKeeper: public Nan::ObjectWrap {
     static Local<String> idAsString (int64_t id) {
         Nan::EscapableHandleScope scope;
         char idbuff [128] = {0};
-        sprintf(idbuff, "%llx", _LL_CAST_ id);
+        snprintf(idbuff, sizeof(idbuff), "%llx", (unsigned long long) id);
         return scope.Escape(LOCAL_STRING(idbuff));
     }
 
@@ -1027,7 +1026,7 @@ class ZooKeeper: public Nan::ObjectWrap {
         CALLBACK_EPILOG();
     }
 
-    static NAN_PROPERTY_GETTER(StatePropertyGetter) {
+    static NAN_GETTER(StatePropertyGetter) {
         assert(info.This().IsEmpty() == false);
         assert(info.This()->IsObject());
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
@@ -1036,25 +1035,25 @@ class ZooKeeper: public Nan::ObjectWrap {
         RETURN_VALUE(info, Nan::New<Integer> (zk->zhandle != 0 ? zoo_state(zk->zhandle) : 0));
     }
 
-    static NAN_PROPERTY_GETTER(ClientidPropertyGetter) {
+    static NAN_GETTER(ClientidPropertyGetter) {
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
         assert(zk);
         RETURN_VALUE(info, zk->idAsString(zk->zhandle != 0 ? zoo_client_id(zk->zhandle)->client_id : zk->myid.client_id));
     }
 
-    static NAN_PROPERTY_GETTER(ClientPasswordPropertyGetter) {
+    static NAN_GETTER(ClientPasswordPropertyGetter) {
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
         assert(zk);
         RETURN_VALUE(info, zk->PasswordToHexString(zk->zhandle != 0 ? zoo_client_id(zk->zhandle)->passwd : zk->myid.passwd));
     }
 
-    static NAN_PROPERTY_GETTER(SessionTimeoutPropertyGetter) {
+    static NAN_GETTER(SessionTimeoutPropertyGetter) {
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
         assert(zk);
         RETURN_VALUE(info, Nan::New<Integer> (zk->zhandle != 0 ? zoo_recv_timeout(zk->zhandle) : -1));
     }
 
-    static NAN_PROPERTY_GETTER(IsUnrecoverablePropertyGetter) {
+    static NAN_GETTER(IsUnrecoverablePropertyGetter) {
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
         assert(zk);
         RETURN_VALUE(info, Nan::New<Integer> (zk->zhandle != 0 ? is_unrecoverable(zk->zhandle) : 0));