Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ListenerCollection::add #81

Open
xepozz opened this issue Feb 13, 2023 · 2 comments
Open

Rename ListenerCollection::add #81

xepozz opened this issue Feb 13, 2023 · 2 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@xepozz
Copy link
Member

xepozz commented Feb 13, 2023

It's better to rename the ListenerCollection::add method to ListenerCollection::withListener because it's not clear that it's immutable
@samdark
Copy link
Member

samdark commented Feb 14, 2023

That would be a BC-breaking change.

@xepozz
Copy link
Member Author

xepozz commented Feb 14, 2023 •
edited
Loading

Just mark it as deprecated and keep both until the next major version

@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @xepozz