Unravel (codecombat#4544)

* PlayGameDevLevelView running world in main thread for better performance

This reduces memory and CPU usage, improves smoothness of playback, and makes keyboard and mouse input more responsive.

It would be close to being able to do test mode in main thread, too, if we wanted.
With a little more work, we would then have no worker threads at all in game dev mode.
Random misc half of fix for loading keyValueDb while playing game dev levels.
Made ?dev=true work for PlayGameDevLevelView.

Would need to think about if we always want Box2D loaded on the main thread.
Would need to standardize on @world.rand.shuffle instead of _.shuffle to use this in maze levels.
Math.random() and _.shuffle in player code may need a fix to make deterministic, not that we teach those yet.
There may be a slight memory leak of old worlds yet to clean up after level restarts.
If we can figure out how to clean up LankBoss Thang stateChanged updates, we'll gain even more performance.
Unrelated to this change, I noticed that our EaselJS click handler gets really unperformant with many sprites on the screen, so for best speed, we'll want to fix that, too.

* Fix some misc stuff

* Add world.rand.shuffleCompat to migrate from using _.shuffle in game engine

* Update CreateJS from somewhere around 0.8 (Nov 2014) to 1.0

TODO: get Sounds working all the way

TODO: take advantage of new StageGL instead of old SpriteStage, where we can now use more than one texture

See createjs.js line 7735 monkeypatching of hit testing for performance increases that we'll want to make sure to preserve in future updates

* Other updates to go along with CreateJS update

* Fix a couple SoundJS and test issues with the CreateJS update

* Try using main thread game dev mode for testing levels, too. TODO: investigate whether memory is leaking.

* Removed test for one-spritesheet-per-container (restriction not needed in new StageGL)

* Fixed the memory leak

* Minor cleanup

* Fix sounds in synchronous game dev

* Fix bug in optimized click hit test in level editor

* Fix game dev levels running out of time when synchronous and indefinite

* Disable rerendering of spritesheets for performance with new StageGL

* Fix rendering spritesheets syncronously blowing up max spritesheet size

* Don't consolidate walls when simulating synchronously to avoid messing with graphics

* Fix wall display during game dev levels

* Don't go crazy on game-dev particles in campaign map

* Clean up some unused code

Author: nwinter

app/lib/Angel.coffee

@@ -149,7 +149,7 @@ module.exports = class Angel extends CocoClass
   finishBeholdingWorld: (goalStates) -> (world) =>
     return if @aborting or @destroyed
     finished = world.frames.length is world.totalFrames
-    if @work?.indefiniteLength and world.victory?
+    if world.indefiniteLength and world.victory?
       finished = true
       world.totalFrames = world.frames.length
     firstChangedFrame = if @work?.indefiniteLength then 0 else world.findFirstChangedFrame @shared.world
@@ -163,8 +163,8 @@ module.exports = class Angel extends CocoClass
       @shared.goalManager?.world = world
       @finishWork()
     else
-      @deserializationQueue.shift()  # Finished with this deserialization.
-      if deserializationArgs = @deserializationQueue[0]  # Start another?
+      @deserializationQueue?.shift()  # Finished with this deserialization.
+      if deserializationArgs = @deserializationQueue?[0]  # Start another?
         @beholdWorld deserializationArgs...
 
   finishWork: ->
@@ -218,11 +218,11 @@ module.exports = class Angel extends CocoClass
     return @say 'Not initialized for work yet.' unless @initialized
     if @shared.workQueue.length
       @work = @shared.workQueue.shift()
-      return _.defer @simulateSync, @work if @work.synchronous
       @say 'Running world...'
       @running = true
       @shared.busyAngels.push @
       @deserializationQueue = []
+      return _.defer @simulateSync, @work if @work.synchronous
       @worker.postMessage func: 'runWorld', args: @work
       clearTimeout @purgatoryTimer
       @say 'Infinite loop timer started at interval of', @infiniteLoopIntervalDuration
@@ -232,16 +232,19 @@ module.exports = class Angel extends CocoClass
       @hireWorker()
 
   abort: ->
-    return unless @worker and @running
+    return unless @running
     @say 'Aborting...'
     @running = false
+    @work?.world?.goalManager?.destroy()
+    @work?.aborted = true
     @work = null
     @streamingWorld = null
     @deserializationQueue = []
     _.remove @shared.busyAngels, @
-    @abortTimeout = _.delay @fireWorker, @abortTimeoutDuration
-    @aborting = true
-    @worker.postMessage func: 'abort'
+    if @worker
+      @abortTimeout = _.delay @fireWorker, @abortTimeoutDuration
+      @aborting = true
+      @worker.postMessage func: 'abort'
 
   fireWorker: (rehire=true) =>
     return if @destroyed
@@ -255,6 +258,7 @@ module.exports = class Angel extends CocoClass
     clearInterval @purgatoryTimer
     @say 'Fired worker.'
     @initialized = false
+    @work?.world?.destroy?()
     @work = null
     @streamingWorld = null
     @deserializationQueue = []
@@ -273,20 +277,29 @@ module.exports = class Angel extends CocoClass
     @worker.addEventListener 'message', @onWorkerMessage
     @worker.creationTime = new Date()
 
-  onFlagEvent: (e) ->
+  onFlagEvent: (flagEvent) ->
     return unless @running and @work.realTime
-    @worker.postMessage func: 'addFlagEvent', args: e
+    if @work.synchronous
+      @work.world.addFlagEvent flagEvent
+    else
+      @worker.postMessage func: 'addFlagEvent', args: flagEvent
 
   onAddRealTimeInputEvent: (realTimeInputEvent) ->
     return unless @running and @work.realTime
-    @worker.postMessage func: 'addRealTimeInputEvent', args: realTimeInputEvent.toJSON()
+    if @work.synchronous
+      @work.world.addRealTimeInputEvent realTimeInputEvent.toJSON()
+    else
+      @worker.postMessage func: 'addRealTimeInputEvent', args: realTimeInputEvent.toJSON()
 
   onStopRealTimePlayback: (e) ->
     return unless @running and @work.realTime
+    if @work.synchronous
+      return @abort()
     @work.realTime = false
     @lastRealTimeWork = new Date()
     @worker.postMessage func: 'stopRealTimePlayback'
 
+
   onEscapePressed: (e) ->
     return unless @running and not @work.realTime
     return if (new Date() - @lastRealTimeWork) < 1000  # Fires right after onStopRealTimePlayback
@@ -296,51 +309,76 @@ module.exports = class Angel extends CocoClass
   simulateSync: (work) =>
     console?.profile? "World Generation #{(Math.random() * 1000).toFixed(0)}" if imitateIE9?
     work.t0 = now()
-    work.world = testWorld = new World work.userCodeMap
+    work.world = new World work.userCodeMap
+    work.world.synchronous = true
     work.world.levelSessionIDs = work.levelSessionIDs
     work.world.submissionCount = work.submissionCount
     work.world.fixedSeed = work.fixedSeed
     work.world.flagHistory = work.flagHistory ? []
-    work.world.difficulty = work.difficulty
-    work.world.loadFromLevel work.level
+    work.world.realTimeInputEvents = work.realTimeInputEvents ? []
+    work.world.difficulty = work.difficulty ? 0
+    work.world.loadFromLevel work.level, true
     work.world.preloading = work.preload
     work.world.headless = work.headless
     work.world.realTime = work.realTime
+    work.world.indefiniteLength = work.indefiniteLength;
+    work.world.justBegin = work.justBegin;
+    work.world.keyValueDb = work.keyValueDb;
     if @shared.goalManager
-      testGM = new GoalManager(testWorld)
-      testGM.setGoals work.goals
-      testGM.setCode work.userCodeMap
-      testGM.worldGenerationWillBegin()
-      testWorld.setGoalManager testGM
-    @doSimulateWorld work
+      goalManager = new GoalManager(work.world)
+      goalManager.setGoals work.goals
+      goalManager.setCode work.userCodeMap
+      goalManager.worldGenerationWillBegin()
+      work.world.setGoalManager goalManager
+    @beginSimulationSync work
+
+  beginSimulationSync: (work) ->
+    work.t1 = now()
+    work.world.worldLoadStartTime = work.t1
+    work.world.lastRealTimeUpdate = 0
+    work.world.realTimeSpeedFactor = 1
+    @simulateFramesSync work, 0
+
+  simulateFramesSync: (work, i) ->
+    return if @destroyed or work.aborted
+    world = work.world
+    i ?= world.frames.length
+    simulationLoopStartTime = now()
+    while i < world.totalFrames
+      if work.realTime
+        progress = world.frames.length / world.totalFrames
+        progress = Math.min(progress, 0.9) if world.indefiniteLength
+        @publishGodEvent 'world-load-progress-changed', progress: progress  # Debounce? Need to publish at all?
+        @streamFrameSync work
+        if world.indefiniteLength and world.victory?
+          world.indefiniteLength = false
+        continuing = world.shouldContinueLoading simulationLoopStartTime, (->), false, (=> @simulateFramesSync(work) unless @destroyed)
+        return unless continuing
+      if world.indefiniteLength and i is world.totalFrames - 1
+        ++world.totalFrames
+      frame = world.getFrame i++  # TODO: better handle non-user-code errors and infinite-loops
+    @finishSimulationSync work
+
+  streamFrameSync: (work) ->
+    goalStates = work.world.goalManager.getGoalStates()
+    @finishBeholdingWorld(goalStates)(work.world)
+
+  finishSimulationSync: (work) ->
+    @publishGodEvent 'world-load-progress-changed', progress: 1
+    work.world.ended = true
+    system.finish work.world.thangs for system in work.world.systems
+    work.t2 = now()
     console?.profileEnd?() if imitateIE9?
-    console.log 'Construction:', (work.t1 - work.t0).toFixed(0), 'ms. Simulation:', (work.t2 - work.t1).toFixed(0), 'ms --', ((work.t2 - work.t1) / testWorld.frames.length).toFixed(3), 'ms per frame, profiled.'
+    console.log 'Construction:', (work.t1 - work.t0).toFixed(0), 'ms. Simulation:', (work.t2 - work.t1).toFixed(0), 'ms --', ((work.t2 - work.t1) / work.world.frames.length).toFixed(3), 'ms per frame, profiled.'
 
     # If performance was really a priority in IE9, we would rework things to be able to skip this step.
-    goalStates = testGM?.getGoalStates()
+    goalStates = work.world.goalManager?.getGoalStates()
     work.world.goalManager.worldGenerationEnded() if work.world.ended
+    @running = false
 
     if work.headless
       simulationFrameRate = work.world.frames.length / (work.t2 - work.t1) * 1000 * 30 / work.world.frameRate
-      @beholdGoalStates {goalStates, overallStatus: testGM.checkOverallStatus(), preload: false, totalFrames: work.world.totalFrames, lastFrameHash: work.world.frames[work.world.totalFrames - 2]?.hash, simulationFrameRate: simulationFrameRate}
+      @beholdGoalStates {goalStates, overallStatus: work.world.goalManager.checkOverallStatus(), preload: false, totalFrames: work.world.totalFrames, lastFrameHash: work.world.frames[work.world.totalFrames - 2]?.hash, simulationFrameRate: simulationFrameRate}
       return
 
-    serialized = world.serialize()
-    window.BOX2D_ENABLED = false
-    World.deserialize serialized.serializedWorld, @shared.worldClassMap, @shared.lastSerializedWorldFrames, @finishBeholdingWorld(goalStates), serialized.startFrame, serialized.endFrame, work.level
-    window.BOX2D_ENABLED = true
-    @shared.lastSerializedWorldFrames = serialized.serializedWorld.frames
-
-  doSimulateWorld: (work) ->
-    work.t1 = now()
-    Math.random = work.world.rand.randf  # so user code is predictable
-    Aether.replaceBuiltin('Math', Math)
-    replacedLoDash = _.runInContext(window)
-    _[key] = replacedLoDash[key] for key, val of replacedLoDash
-    i = 0
-    while i < work.world.totalFrames
-      frame = work.world.getFrame i++
-    @publishGodEvent 'world-load-progress-changed', progress: 1
-    work.world.ended = true
-    system.finish work.world.thangs for system in work.world.systems
-    work.t2 = now()
+    @shared.lastSerializedWorldFrames = work.world.frames

app/lib/AudioPlayer.coffee

@@ -8,12 +8,7 @@ createjs = require 'lib/createjs-parts'
 rot13 = (s) -> s.replace /[A-z]/g, (c) -> String.fromCharCode c.charCodeAt(0) + (if c.toUpperCase() <= 'M' then 13 else -13)
 swears = (rot13 s for s in ['nefrubyr', 'nffubyr', 'onfgneq', 'ovgpu', 'oybbql', 'obyybpxf', 'ohttre', 'pbpx', 'penc', 'phag', 'qnza', 'qnea', 'qvpx', 'qbhpur', 'snt', 'shpx', 'cvff', 'chffl', 'fuvg', 'fyhg', 'svqqyrfgvpxf'])
 
-# IE(11, 10, 9) throws an exception if createjs.FlashPlugin is undefined
-# Chrome and Firefox don't seem to care that it's undefined
-if createjs.FlashPlugin?
-  soundPlugins = [createjs.WebAudioPlugin, createjs.FlashPlugin, createjs.HTMLAudioPlugin]
-else
-  soundPlugins = [createjs.WebAudioPlugin, createjs.HTMLAudioPlugin]
+soundPlugins = [createjs.WebAudioPlugin, createjs.HTMLAudioPlugin]
 createjs.Sound.registerPlugins(soundPlugins)
 
 class Manifest
@@ -44,7 +39,7 @@ class AudioPlayer extends CocoClass
 
   constructor: () ->
     super()
-    @ext = if createjs.Sound.getCapability('mp3') then '.mp3' else '.ogg'
+    @ext = if createjs.Sound.capabilities.mp3 then '.mp3' else '.ogg'
     @camera = null
     @listenToSound()
     @createNewManifest()