Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate acknowledgement in Settings bundle #1435

Open
pafdad opened this issue Jan 2, 2024 · 5 comments
Open

Generate acknowledgement in Settings bundle #1435

pafdad opened this issue Jan 2, 2024 · 5 comments

Comments

@pafdad
Copy link

pafdad commented Jan 2, 2024

Hello and thank you for Xcodegen

Can Xcodegen help in generating the acknowledgements.plist for a Settings.bundle, like CocoaPods does?

Thank you in advance

@markst
Copy link
Contributor

markst commented Jan 9, 2024

Personally seems a bit out of scope for Xcodegen. You might consider using a tool such as: https://github.com/mono0926/LicensePlist

@pafdad
Copy link
Author

pafdad commented Jan 10, 2024

@markst thank you for your response

So a tool like that will have to have access to SPM's Package.swift file, which is a file managed by Xcodegen. When we use Xcodegen we don't actually manage the Package.swift file manually. Instead we are telling Xcodegen which dependencies we need. So it seems appropriate that the application that manages the actual dependencies (Xcodegen) generates also the acknowledgements for them.

This is true in case of Cocoapods as well. In that case Cocoapods is managing the dependencies, hence it's able to generate the acknowledgements for them too.

Regards

@markst
Copy link
Contributor

markst commented Jan 11, 2024

The LicensePlist uses the project.xcworkspace/xcshareddata/swiftpm/Package.resolved in order to generate the output Acknowledgements. This file file will exist after a project generated by XcodeGen has resolved dependencies.

So in order to use LicensePlist you can update your project.yml to add a buildToolPlugins to execute the LicensePlistBuildTool. I'm happy to create a demonstration as an example if it's not clear.

@markst
Copy link
Contributor

markst commented Jan 11, 2024

You might hit a blocker trusting the build tool - "Trust & Enable All".
Depending on how you are running your build you could pass -skipPackagePluginValidation to your xcodebuild.

@yonaskolb
Copy link
Owner

Thanks for the info here @markst, I learned something too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants