From ba0911547911e007ee56d17b16d10d5a84be3259 Mon Sep 17 00:00:00 2001 From: Donghwan Jeung Date: Mon, 23 Dec 2024 13:45:19 +0900 Subject: [PATCH] Add `.nvmrc` to specify Node.js version (#429) * chore: specify node version v18 * chore(.github/workflows): update actions/setup-node to use 'node-version-file' instead of 'node-version --- .github/workflows/ci_backend.yaml | 5 +---- .github/workflows/ci_frontend.yaml | 7 ++----- .github/workflows/desktop-publish.yml | 3 +-- .github/workflows/gh_pages.yaml | 2 +- .nvmrc | 1 + 5 files changed, 6 insertions(+), 12 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/ci_backend.yaml b/.github/workflows/ci_backend.yaml index 052d65b5..872e1884 100644 --- a/.github/workflows/ci_backend.yaml +++ b/.github/workflows/ci_backend.yaml @@ -16,9 +16,6 @@ jobs: test: name: Check the source code runs-on: ubuntu-latest - strategy: - matrix: - node-version: [18.x] env: working-directory: ./backend steps: @@ -29,7 +26,7 @@ jobs: - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node-version }} + node-version-file: '.nvmrc' cache: "pnpm" - name: Install packages run: pnpm install --frozen-lockfile diff --git a/.github/workflows/ci_frontend.yaml b/.github/workflows/ci_frontend.yaml index 0a5ce742..d16fa7a2 100644 --- a/.github/workflows/ci_frontend.yaml +++ b/.github/workflows/ci_frontend.yaml @@ -16,9 +16,6 @@ jobs: test: name: Check the source code runs-on: ubuntu-latest - strategy: - matrix: - node-version: [18.x] env: working-directory: ./frontend steps: @@ -26,10 +23,10 @@ jobs: uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 - - name: Use Node.js ${{ matrix.node-version }} + - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node-version }} + node-version-file: '.nvmrc' cache: "pnpm" - name: Install packages run: pnpm install --frozen-lockfile diff --git a/.github/workflows/desktop-publish.yml b/.github/workflows/desktop-publish.yml index a40c6d85..bed9e01f 100644 --- a/.github/workflows/desktop-publish.yml +++ b/.github/workflows/desktop-publish.yml @@ -9,7 +9,6 @@ jobs: strategy: matrix: os: [macos-latest, ubuntu-latest, windows-latest] - node-version: [18.x] defaults: run: @@ -22,7 +21,7 @@ jobs: - name: Install Node.js uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node-version }} + node-version-file: '.nvmrc' - name: Set up pnpm uses: pnpm/action-setup@v4 diff --git a/.github/workflows/gh_pages.yaml b/.github/workflows/gh_pages.yaml index eaebbb09..d1bce83e 100644 --- a/.github/workflows/gh_pages.yaml +++ b/.github/workflows/gh_pages.yaml @@ -17,7 +17,7 @@ jobs: - name: Setup Node 🔧 uses: actions/setup-node@v4 with: - node-version: "18" + node-version-file: '.nvmrc' cache: "pnpm" cache-dependency-path: pnpm-lock.yaml diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..0828ab79 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +v18 \ No newline at end of file