Fix issue of referencing process object on browser#778
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 81.87% 81.92% +0.05%
==========================================
Files 59 59
Lines 4337 4338 +1
Branches 851 852 +1
==========================================
+ Hits 3551 3554 +3
+ Misses 533 532 -1
+ Partials 253 252 -1 ☔ View full report in Codecov by Sentry. |
hackerwins
self-requested a review
April 17, 2024 16:54
hackerwins
approved these changes
Apr 17, 2024
hackerwins
left a comment
hackerwins
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR do type-check first to avoid referencing the process object to prevents type issues when using the yorkie-js-sdk in a web browser via a CDN, etc.
Any background context you want to provide?
What are the relevant tickets?
Fixes #768
Checklist