-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC and versionVector handling in documents created after v0.5.6 #1081
Labels
bug 🐞
Something isn't working
Comments
3 tasks
hackerwins
added a commit
that referenced
this issue
Feb 11, 2025
This commit extends RWMutex interface for locker package. The original plan was to implement RWMutex for maintaining consistency in updateVersionVector during PushPull operations(#1081). However, this change is currently on hold due to the following reasons: 1. A bug was discovered in Lamport removal logic: #1089 2. The removal logic has been deprecated since v0.5.7 This commit includes only the interface extension while the actual implementation will be addressed in a future update. --------- Co-authored-by: Youngteac Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
Starting from v0.5.6, there was a change where the browser is now able to
deactivate
the client during thebeforeunload
in CodePair, leading to GC being processed.However, when testing documents created after v0.5.6, the following issues were observed:
doc.getGarbageLen()
on documents created after v0.5.6 appears to correctly remove garbage under normal conditions.doc.changeID.versionVector
anddoc.presences
. Occasionally,versionVector
does not decrease, whilepresences
appear to be cleaned up correctly.What you expected to happen:
The expectation is that GC should function correctly for both documents created after v0.5.6, ensuring that both
doc.presences
andversionVector
maintain corresponding sizes.How to reproduce it (as minimally and precisely as possible):
https://codepair.yorkie.dev/hackerwins/674522059b55661e04668721/share?token=c5uq0y
Anything else we need to know?:
Related to #723
Environment:
yorkie version
): v0.5.6The text was updated successfully, but these errors were encountered: