-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Client.Watch inside Client.Attach and hide it from external interface #584
Comments
It looks interesting. May I work on this issue? |
@karockai sure! give it a try! |
Do we need to change the entire interface to perform |
@krapie Yes, that seems necessary. |
Following #803, we need to apply the below features:
|
Description:
Move
Client.Watch
insideClient.Attach
and hide it from the external interface.Go SDK is just used in integration tests of servers without other SDK installations. So it was OK to expose
Client.Watch
to the external interface. But by adding more and more features to the SDK, it is quite difficult to keep simple tests.Let's move Client.Watch inside Client.Attach and hide it from the external interface to maintain consistency with other SDKs and simplify testing.
Why:
Keep the product simple
The text was updated successfully, but these errors were encountered: