Skip to content

Conversation

@Racer159
Copy link
Contributor

@Racer159 Racer159 commented Nov 21, 2025

Description

Changes the behavior around Zarf values files to merge on create instead of on deploy.

Caution

Breaking Change
This change is breaking for packages that use the alpha Zarf Values feature - these packages will need to be recreated with a new version of Zarf to be deployed by that version of Zarf. (other packages not using this feature will be unaffected)

Related Issue

Fixes #4302

Checklist before merging

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 47211b5
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6924fded56aae400091cf126
😎 Deploy Preview https://deploy-preview-4403--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Racer159 Racer159 force-pushed the fix/allow-anywhere-values-files branch from 8198d36 to 56572f6 Compare November 21, 2025 22:35
@Racer159 Racer159 force-pushed the fix/allow-anywhere-values-files branch from 56572f6 to 5e4cbec Compare November 21, 2025 22:40
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 43.90244% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/layout/assemble.go 31.81% 11 Missing and 4 partials ⚠️
src/pkg/packager/deploy.go 0.00% 8 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/value/value.go 85.43% <100.00%> (+2.09%) ⬆️
src/pkg/packager/load/import.go 51.88% <100.00%> (+1.37%) ⬆️
src/pkg/packager/deploy.go 0.00% <0.00%> (ø)
src/pkg/packager/layout/assemble.go 43.77% <31.81%> (+1.37%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Wayne Starr <[email protected]>
Signed-off-by: Wayne Starr <[email protected]>
@Racer159 Racer159 marked this pull request as ready for review November 24, 2025 18:33
@Racer159 Racer159 requested review from a team as code owners November 24, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

remove expectation for values files defined in a package config to be within a directory called values

1 participant