Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where/how to support fsspec synchronous-only filesystems #2468

Closed
moradology opened this issue Nov 6, 2024 · 1 comment
Closed

Where/how to support fsspec synchronous-only filesystems #2468

moradology opened this issue Nov 6, 2024 · 1 comment

Comments

@moradology
Copy link

moradology commented Nov 6, 2024

In the process of trying to support changes for zarr v3 in kerchunk (issue here), I've implemented a little wrapper to make synchronous filesystem instances into AsyncFileSystems (pr here).

Unfortunately, in the process of applying necessary changes to get tests working in kerchunk, the simplest path was to modify the from_url method on RemoteStore. This becomes - roughly - this:
image

I get the sense that people may not want this kind of workaround in zarr-python itself but it's a bit difficult to see what the alternative is if we're going to support a code path using fsspec's url_to_fs utility. Thoughts?

@moradology
Copy link
Author

Closing after conversation in #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant