quote variables in shell script

Author: zbhavyai

chrome-tigervnc/start.sh

@@ -3,21 +3,21 @@ set -euo pipefail
 
 # start Xvnc server
 echo "[INFO] Starting Xvnc server"
-Xvnc -quiet ${DISPLAY} -SecurityTypes None -geometry ${RESOLUTION} -depth 24 &>/dev/null &
+Xvnc -quiet "${DISPLAY}" -SecurityTypes None -geometry "${RESOLUTION}" -depth 24 &>/dev/null &
 PID_XVNC=$!
 
 # wait for Xvnc to start
 sleep 3
 
 # start openbox
 echo "[INFO] Starting Openbox"
-DISPLAY=${DISPLAY} openbox-session &
+DISPLAY="${DISPLAY}" openbox-session &
 PID_OPENBOX=$!
 
 # launch Chrome in a respawn loop
 while true; do
     echo "[INFO] Launching Chrome"
-    DISPLAY=${DISPLAY} google-chrome \
+    DISPLAY="${DISPLAY}" google-chrome \
         --disable-gpu \
         --disable-software-rasterizer \
         --disable-dev-shm-usage \

firefox-tigervnc/start.sh

@@ -3,21 +3,21 @@ set -euo pipefail
 
 # start Xvnc server
 echo "[INFO] Starting Xvnc server"
-Xvnc -quiet ${DISPLAY} -SecurityTypes None -geometry ${RESOLUTION} -depth 24 &>/dev/null &
+Xvnc -quiet "${DISPLAY}" -SecurityTypes None -geometry "${RESOLUTION}" -depth 24 &>/dev/null &
 PID_XVNC=$!
 
 # wait for Xvnc to start
 sleep 3
 
 # start openbox
 echo "[INFO] Starting Openbox"
-DISPLAY=${DISPLAY} openbox-session &
+DISPLAY="${DISPLAY}" openbox-session &
 PID_OPENBOX=$!
 
 # launch Firefox in a respawn loop
 while true; do
     echo "[INFO] Launching Firefox"
-    DISPLAY=${DISPLAY} firefox \
+    DISPLAY="${DISPLAY}" firefox \
         --width=1920 \
         --height=1080 \
         &>/dev/null