Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to sort submissions (#22) #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuperCl4sh
Copy link

Fixes #22.

@SuperCl4sh
Copy link
Author

Due to the nature of select2.js, users are able to enter multiple sort options, which is entirely useless since the probability of having a tie to break is near zero. In the future, perhaps it would be worth resolving this minor issue.

@zecookiez
Copy link
Owner

Looks promising, but the sort option seems to be broken on the Best Submissions tab:

image

Sorting seems to be going in descending order on the All submissions tab, not sure if that's intended?

@SuperCl4sh
Copy link
Author

SuperCl4sh commented Aug 14, 2022

I believe it appeared to be sorted that way due to the Best Solution tab overriding the sorting options with runtime ascending. I have changed this and added ascending and descending sorting options for memory and runtime. In the future, perhaps a sorting option for submission source size could be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different sorting options for Best Submission page
2 participants