129 fix debugger path (#130)

Fixes #129 
Previously non-existing debugger path would error and not download the
debugger due to remove_dir_all failing on nonexistent directory.

Author: playdohface

Cargo.lock

@@ -1,7 +1,7 @@
 
 [package]
 name = "zed_java"
-version = "6.7.0"
+version = "6.7.1"
 edition = "2024"
 publish = false
 license = "Apache-2.0"

Cargo.toml

@@ -1,6 +1,6 @@
 id = "java"
 name = "Java"
-version = "6.7.0"
+version = "6.7.1"
 schema_version = 1
 authors = [
     "Valentine Briese <[email protected]>",

extension.toml

@@ -11,7 +11,7 @@ use zed_extension_api::{
 
 use crate::{
     lsp::LspWrapper,
-    util::{get_curr_dir, path_to_string},
+    util::{create_path_if_not_exists, get_curr_dir, path_to_string},
 };
 
 #[derive(Serialize, Deserialize, Debug)]
@@ -104,8 +104,7 @@ impl Debugger {
             return Ok(path.clone());
         }
 
-        fs::remove_dir_all(prefix).map_err(|err| err.to_string())?;
-        fs::create_dir(prefix).map_err(|err| err.to_string())?;
+        create_path_if_not_exists(prefix)?;
 
         download_file(
             JAVA_DEBUG_PLUGIN_FORK_URL,

src/debugger.rs

@@ -5,8 +5,9 @@ use std::{
     path::{Path, PathBuf},
 };
 use zed_extension_api::{
-    self as zed, Command, LanguageServerId, Os, Worktree, current_platform, serde_json::Value,
-    http_client::{HttpMethod, HttpRequest, fetch}
+    self as zed, Command, LanguageServerId, Os, Worktree, current_platform,
+    http_client::{HttpMethod, HttpRequest, fetch},
+    serde_json::Value,
 };
 
 use crate::{
@@ -28,6 +29,33 @@ const TAG_RETRIEVAL_ERROR: &str = "Failed to fetch GitHub tags";
 const TAG_RESPONSE_ERROR: &str = "Failed to deserialize GitHub tags response";
 const TAG_UNEXPECTED_FORMAT_ERROR: &str = "Malformed GitHub tags response";
 
+/// Create a Path if it does not exist
+///
+/// **Errors** if a file that is not a path exists at the location or read/write access failed for the location
+///
+///# Arguments
+/// * [`path`] the path to create
+///
+///# Returns
+///
+/// Ok(()) if the path exists or was created successfully
+pub fn create_path_if_not_exists<P: AsRef<Path>>(path: P) -> zed::Result<()> {
+    let path_ref = path.as_ref();
+    match fs::metadata(path_ref) {
+        Ok(metadata) => {
+            if metadata.is_dir() {
+                Ok(())
+            } else {
+                Err(format!("File exists but is not a path: {:?}", path_ref))
+            }
+        }
+        Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
+            fs::create_dir_all(path_ref).map_err(|e| e.to_string())
+        }
+        Err(e) => Err(e.to_string()),
+    }
+}
+
 /// Expand ~ on Unix-like systems
 ///
 /// # Arguments