Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Troublesome attribute value gets cleared silently. #236

@bitwombat

Description

@bitwombat

This code in AbstractHelper.php has the effect of silently failing:

        try {
            $escapedAttribute = $escapeAttr($value);
            $strings[] = sprintf('%s="%s"', $escape($key), $escapedAttribute);
        } catch (EscaperException $x) {
            // If an escaper exception happens, escape only the key, and use a blank value.
            $strings[] = sprintf('%s=""', $escape($key));
        }

Some problem with my attribute value was resulting in an exception and thus a blank value, as intended by the above code. I would have much preferred seeing the exception, instead of having to trace it down to this bit of code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions